refactor: enhance readability of output logs and errors#1528
Merged
Conversation
chaoticlonghair
requested review from
blckngm and
jjyr
and removed request for
blckngm and
jjyr
Flouse
approved these changes
Nov 7, 2023
KaoImin
approved these changes
Nov 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
This PR enhances readability of output logs and errors.
Before this PR, there are many formats:
ethereum_types::H64{}is01ff....04ff.{:#x}is0x01ff02ff03ff04ff.bytes::Bytes{:?}isb"\xad@\xe1\xab\xcb\xa9F{6\x01\xa8".{:#x}is01ff02ff03ff04ff.Difference with
ethereum_types::Hxxx, there is no 0x-prefix.Vec<u8>{:?}is[1, 255, 2, 255, 3, 255, 4, 255].The following changes are applied:
b"\xad@\xe1\xab\xcb\xa9F{6\x01\xa8"to0x01ff02ff03ff04ff.[1, 255, 2, 255, 3, 255, 4, 255]to0x01ff02ff03ff04ff.01ff....04ffto0x01ff02ff03ff04ff.What is the impact of this PR?
No Breaking Change
CI Settings
CI Usage
Tip: Check the CI you want to run below, and then comment
/run-ci.CI Switch
CI Description