Conversation
b46a295 to
9790514
Compare
4ebbd9b to
ae897df
Compare
ae897df to
a89018d
Compare
KaoImin
approved these changes
Oct 10, 2023
This comment was marked as off-topic.
This comment was marked as off-topic.
CI tests run on commit:
CI test list:
Please check ci test results later. |
driftluo
approved these changes
Oct 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
This PR closes #1305.
Since no genesis transaction is allowed after #1454 merged:
transactions_rootshould always be the default valueRLP_NULLas a normal block.axon/core/consensus/src/engine.rs
Lines 75 to 83 in 412e52a
signed_txs_hashshould always be the default valueRLP_EMPTY_LISTas a normal blockaxon/core/consensus/src/engine.rs
Line 115 in 412e52a
axon/core/consensus/src/util.rs
Lines 19 to 25 in 412e52a
receipts_rootshould always be the default valueRLP_NULLas a normal block.axon/core/executor/src/lib.rs
Lines 188 to 196 in 412e52a
log_bloomshould always calculated from an empty logs vector.axon/protocol/src/types/block.rs
Lines 132 to 136 in 412e52a
axon/protocol/src/types/block.rs
Lines 145 to 147 in 412e52a
Default::default().The
Default::default()is all zeros, but for an empty logs vector, it's not.The difference is as following:
gas_usedshould always be zero.What is the impact of this PR?
No Breaking Change
CI Settings
CI Usage
Tip: Check the CI you want to run below, and then comment
/run-ci.CI Switch
CI Description