chore: add health check in docker#1452
Merged
Flouse merged 2 commits intoaxonweb3:mainfrom Sep 28, 2023
Merged
Conversation
1 task
Simon-Tl
approved these changes
Sep 27, 2023
Flouse
requested review from
a team,
chaoticlonghair,
jiangxianliang007 and
jjyr
and removed request for
a team and
jjyr
KaoImin
changed the title
jiangxianliang007
approved these changes
Sep 28, 2023
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
Without
curlandjq, devtools/docker/health_check.sh was not working previously in the Axon docker container.This PR fixed the Dockerfile and add healthcheck into the quick-start docker-compose file, to test it.
docker compose up -d --waitwill wait for services to be running|healthy.What is the impact of this PR?
No Breaking Change
PR relation:
Test
chain-axon-1
ghcr.io/flouse/axon:healthcheck-in-docker-dev
"/bin/sh -c /app/devtools/docker/docker-entrypoint.sh"
Up 31 seconds (healthy)
https://github.com/Flouse/axon/actions/runs/6314701964/job/17146622945#step:6:622
CI Settings
CI Usage
Tip: Check the CI you want to run below, and then comment
/run-ci.CI Switch
CI Description