Skip to content

refactor: initialize chain without user-provided genesis transactions file#1450

Merged
Flouse merged 1 commit intomainfrom
yangby/refactor/init-chain-without-transactions
Sep 26, 2023
Merged

refactor: initialize chain without user-provided genesis transactions file#1450
Flouse merged 1 commit intomainfrom
yangby/refactor/init-chain-without-transactions

Conversation

@chaoticlonghair
Copy link
Copy Markdown
Contributor

@chaoticlonghair chaoticlonghair commented Sep 26, 2023

What this PR does / why we need it?

Initialize chain without user-provided genesis transactions file.

The data in the transaction file will be re-written, so this file is useless, it could be removed.

ℹ️ This change doesn't change the preset hashes in unit tests.

CI Settings

CI Usage

Tip: Check the CI you want to run below, and then comment /run-ci.

CI Switch

  • Web3 Compatible Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests

CI Description

CI Name Description
Web3 Compatible Test Test the Web3 compatibility of Axon
v3 Core Test Run the compatibility tests provided by Uniswap V3
OCT 1-5 | 6-10 | 11 | 12-15 | 16-19 Run the compatibility tests provided by OpenZeppelin

@KaoImin
Copy link
Copy Markdown
Contributor

KaoImin commented Sep 26, 2023

/run-ci

@github-actions
Copy link
Copy Markdown

CI tests run on commit:

CI test list:

  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests
  • Web3 Compatible Tests

Please check ci test results later.

@Flouse Flouse added this pull request to the merge queue Sep 26, 2023
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 26, 2023
@chaoticlonghair chaoticlonghair added this pull request to the merge queue Sep 26, 2023
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 26, 2023
@Flouse Flouse added this pull request to the merge queue Sep 26, 2023
Merged via the queue into main with commit 47e7407 Sep 26, 2023
@Flouse Flouse linked an issue Sep 26, 2023 that may be closed by this pull request
20 tasks
@KaoImin KaoImin deleted the yangby/refactor/init-chain-without-transactions branch October 12, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The genesis transactions are opaque with poor readability Transactions root of genesis block is incorrect

3 participants