chore: use another complex id as default chain id#1418
Merged
Conversation
KaoImin
approved these changes
Sep 11, 2023
chaoticlonghair
commented
Sep 11, 2023
Flouse
approved these changes
Sep 11, 2023
chaoticlonghair
added a commit
that referenced
this pull request
Sep 12, 2023
7 tasks
Contributor
cc @sunchengzhu |
Flouse
added a commit
that referenced
this pull request
Sep 14, 2023
This was referenced Sep 14, 2023
driftluo
pushed a commit
that referenced
this pull request
Sep 19, 2023
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Sep 19, 2023
* feat: hardfork subcommand * fix: fix the difference between enabled and determined * Update core/api/src/jsonrpc/impl/axon.rs Co-authored-by: Flouse <[email protected]> * Update core/consensus/src/engine.rs Co-authored-by: Flouse <[email protected]> * docs: the default dev chain id is changed since #1418 (#1434) * chore(Dockerfile): add health-check shell script (#1432) * ci: add health-check shell script * ci: remove blank line --------- Co-authored-by: Flouse <[email protected]> --------- Co-authored-by: Flouse <[email protected]> Co-authored-by: Simon <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
This PR resolves #1337.
What is the impact of this PR?
No Breaking Change
Special notes for your reviewer:
Current solution is not the final solution.
I just propose a chain ID which I think it is not prone to be conflicted.
Any ideas are welcome.
CI Settings
CI Usage
Tip: Check the CI you want to run below, and then comment
/run-ci.CI Switch
CI Description
cargo clippy --all --all-targets --all-featurescargo +nightly fmt --all -- --checkandcargo sort -gwc