Conversation
KaoImin
requested review from
Flouse,
Simon-Tl,
ashuralyk and
chaoticlonghair
and removed request for
ashuralyk
This comment was marked as off-topic.
This comment was marked as off-topic.
chaoticlonghair
previously approved these changes
Aug 29, 2023
This comment was marked as outdated.
This comment was marked as outdated.
KaoImin
force-pushed
the
refactor-hex-codec
branch
from
c9f50c5 to
e6f30d1
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
1 similar comment
This comment was marked as off-topic.
This comment was marked as off-topic.
KaoImin
force-pushed
the
refactor-hex-codec
branch
from
e6f30d1 to
02d4e51
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
KaoImin
force-pushed
the
refactor-hex-codec
branch
from
7950fef to
7ad4beb
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
CI tests run on commit:
CI test list:
Please check ci test results later. |
driftluo
approved these changes
Aug 30, 2023
Flouse
approved these changes
Aug 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
This PR change the rlp codec of
Hex.The previous implement convert
HexasStringand the current implement convert it asVec<u8>. This saves half of the space, however, it is a breaking change.What is the impact of this PR?
PR relation:
CI Settings
CI Usage
Tip: Check the CI you want to run below, and then comment
/run-ci.CI Switch
CI Description
cargo clippy --all --all-targets --all-featurescargo +nightly fmt --all -- --checkandcargo sort -gwc