Skip to content

fix(API): gas limit conversion error#1344

Merged
chaoticlonghair merged 1 commit intomainfrom
fix-conversion-error
Aug 22, 2023
Merged

fix(API): gas limit conversion error#1344
chaoticlonghair merged 1 commit intomainfrom
fix-conversion-error

Conversation

@driftluo
Copy link
Copy Markdown
Contributor

@driftluo driftluo commented Aug 22, 2023 •
edited by KaoImin
Loading

What this PR does / why we need it?

This PR fix conversion error on the transaction， which don't use zero to default gas value

What is the impact of this PR?

No Breaking Change

CI Settings

CI Usage

Tip: Check the CI you want to run below, and then comment /run-ci.

CI Switch

  • Cargo Clippy
  • Coverage Test
  • E2E Tests
  • Code Format
  • Unit Tests
  • Web3 Compatible Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests

CI Description

CI Name Description
Chaos CI Test the liveness and robustness of Axon under terrible network condition
Cargo Clippy Run cargo clippy --all --all-targets --all-features
Coverage Test Get the unit test coverage report
E2E Test Run end-to-end test to check interfaces
Code Format Run cargo +nightly fmt --all -- --check and cargo sort -gwc
Web3 Compatible Test Test the Web3 compatibility of Axon
v3 Core Test Run the compatibility tests provided by Uniswap V3
OCT 1-5 | 6-10 | 11 | 12-15 | 16-19 Run the compatibility tests provided by OpenZeppelin

@driftluo driftluo requested a review from a team as a code owner August 22, 2023 03:14
KaoImin
KaoImin reviewed Aug 22, 2023
View reviewed changes
Comment thread core/api/src/jsonrpc/web3_types.rs Outdated
chaoticlonghair
chaoticlonghair reviewed Aug 22, 2023
View reviewed changes
Comment thread core/api/src/jsonrpc/web3_types.rs Outdated
@driftluo driftluo force-pushed the fix-conversion-error branch from d6abe76 to 8b7b1b9 Compare August 22, 2023 03:17
@KaoImin

This comment was marked as off-topic.

Sign in to view
@axon-bot
Copy link
Copy Markdown

axon-bot Bot commented Aug 22, 2023

CI tests run on commit:

CI test list:

  • Code Format
  • Cargo Clippy
  • E2E Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • Unit Tests
  • v3 Core Tests
  • Web3 Compatible Tests

Please check ci test results later.

@KaoImin KaoImin changed the title fix: fix conversion error fix(API): gas limit conversion error Aug 22, 2023
@chaoticlonghair chaoticlonghair added this pull request to the merge queue Aug 22, 2023
Merged via the queue into main with commit 306e327 Aug 22, 2023
@driftluo driftluo deleted the fix-conversion-error branch August 22, 2023 07:14
KaoImin pushed a commit that referenced this pull request Aug 25, 2023
@driftluo
fix(API): gas limit conversion error (#1344)
8fa748f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@KaoImin KaoImin KaoImin approved these changes

@chaoticlonghair chaoticlonghair chaoticlonghair approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bugfix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@driftluo @KaoImin @chaoticlonghair