Skip to content

refactor: use derive apis to parse command line arguments#1326

Merged
Flouse merged 1 commit intomainfrom
yangby/refactor/split-run-command
Aug 16, 2023
Merged

refactor: use derive apis to parse command line arguments#1326
Flouse merged 1 commit intomainfrom
yangby/refactor/split-run-command

Conversation

@chaoticlonghair
Copy link
Copy Markdown
Contributor

@chaoticlonghair chaoticlonghair commented Aug 16, 2023

What this PR does / why we need it:

This PR:

  • Use derive APIs to parse command line arguments.
  • Split the code so that the code of different sub-commands won't interfere with each other.

Which issue(s) this PR fixes:

Original issue was:

... I think it's a good time to switch to derived commands to reduce boilerplate and to make getting arguments less error-prone.

Which toolchain this PR adaption:

No Breaking Change

CI Settings

CI Description

CI Name Description
Chaos CI Test the liveness and robustness of Axon under terrible network condition
Cargo Clippy Run cargo clippy --all --all-targets --all-features
Coverage Test Get the unit test coverage report
E2E Test Run end-to-end test to check interfaces
Code Format Run cargo +nightly fmt --all -- --check and cargo sort -gwc
Web3 Compatible Test Test the Web3 compatibility of Axon
v3 Core Test Run the compatibility tests provided by Uniswap V3
OCT 1-5 | 6-10 | 11 | 12-15 | 16-19 Run the compatibility tests provided by OpenZeppelin

CI Usage

Check the CI you want to run below, and then comment /run-ci.

CI Switch

  • Chaos CI
  • Cargo Clippy
  • Coverage Test
  • E2E Tests
  • Code Format
  • Unit Tests
  • Web3 Compatible Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests

@chaoticlonghair chaoticlonghair requested a review from a team as a code owner August 16, 2023 03:37
@chaoticlonghair chaoticlonghair requested review from Flouse, KaoImin, blckngm and driftluo and removed request for ahonn and ashuralyk August 16, 2023 03:38
@chaoticlonghair
Copy link
Copy Markdown
Contributor Author

chaoticlonghair commented Aug 16, 2023

/run-ci

@axon-bot
Copy link
Copy Markdown

axon-bot Bot commented Aug 16, 2023

CI tests run on commit:

CI test list:

  • Code Format
  • Cargo Clippy
  • E2E Tests
  • Unit Tests

Please check ci test results later.

@Flouse Flouse added this pull request to the merge queue Aug 16, 2023
Merged via the queue into main with commit 148a302 Aug 16, 2023
@Flouse Flouse deleted the yangby/refactor/split-run-command branch August 16, 2023 05:02
KaoImin pushed a commit that referenced this pull request Aug 25, 2023
@chaoticlonghair
refactor: use derive apis to parse command line arguments (#1326)
b76b729
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Flouse Flouse Flouse approved these changes

@driftluo driftluo Awaiting requested review from driftluo

+2 more reviewers

@blckngm blckngm blckngm approved these changes

@KaoImin KaoImin KaoImin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chaoticlonghair @Flouse @blckngm @KaoImin