Merged
Conversation
chaoticlonghair
requested review from
Flouse,
KaoImin and
driftluo
and removed request for
felicityin and
jjyr
3 tasks
Flouse
approved these changes
Aug 15, 2023
KaoImin
approved these changes
Aug 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR fix a CI issue which was introduced in #1319, cause by a directory renaming.
The CI error is thrown directly by the following code:
axon/.github/workflows/axon-start-with-short-genesis.yml
Line 32 in 680e53e
IMHO, the original directory name, "geneses", is correct.
Because:
So, axon uses plural form as name for file collections.
So I just revert the renaming.
Which toolchain this PR adaption:
No Breaking Change
Special notes for your reviewer:
NIL
CI Description
cargo clippy --all --all-targets --all-featurescargo +nightly fmt --all -- --checkandcargo sort -gwcCI Usage
CI Switch