Skip to content

perf: reduce mem cost on modexp#1300

Merged
KaoImin merged 1 commit intomainfrom
reduce-mem-use-on-mod-exp
Aug 4, 2023
Merged

perf: reduce mem cost on modexp#1300
KaoImin merged 1 commit intomainfrom
reduce-mem-use-on-mod-exp

Conversation

@driftluo
Copy link
Copy Markdown
Contributor

@driftluo driftluo commented Aug 3, 2023 •
edited by KaoImin
Loading

What this PR does / why we need it:

This PR reduces mem cost on modexp. Compute gas cost using independent resolution scheme

Which issue(s) this PR fixes:

Fixes #

Which docs this PR relation:

Ref #

Which toolchain this PR adaption:

No Breaking Change

Special notes for your reviewer:

NIL

CI Description

CI Name Description
Chaos CI Test the liveness and robustness of Axon under terrible network condition
Cargo Clippy Run cargo clippy --all --all-targets --all-features
Coverage Test Get the unit test coverage report
E2E Test Run end-to-end test to check interfaces
Code Format Run cargo +nightly fmt --all -- --check and cargo sort -gwc
Web3 Compatible Test Test the Web3 compatibility of Axon
v3 Core Test Run the compatibility tests provided by Uniswap V3
OCT 1-5 | 6-10 | 11 | 12-15 | 16-19 Run the compatibility tests provided by OpenZeppelin

CI Usage

Check the CI you want to run below, and then comment /run-ci.

CI Switch

  • Chaos CI
  • Cargo Clippy
  • Coverage Test
  • E2E Tests
  • Code Format
  • Unit Tests
  • Web3 Compatible Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests

@driftluo driftluo requested a review from a team as a code owner August 3, 2023 07:46
@driftluo driftluo requested review from Simon-Tl and felicityin August 3, 2023 07:46
@github-actions github-actions Bot added the enhancement New feature or request label Aug 3, 2023
blckngm
blckngm reviewed Aug 3, 2023
View reviewed changes
Comment thread core/executor/src/precompiles/modexp.rs Outdated
blckngm
blckngm reviewed Aug 3, 2023
View reviewed changes
Comment thread core/executor/src/precompiles/modexp.rs Outdated
@driftluo driftluo force-pushed the reduce-mem-use-on-mod-exp branch from 15b13d7 to 1304a32 Compare August 3, 2023 09:04
blckngm
blckngm reviewed Aug 3, 2023
View reviewed changes
Comment thread core/executor/src/precompiles/modexp.rs Outdated
@driftluo driftluo force-pushed the reduce-mem-use-on-mod-exp branch from 1304a32 to 110ee3c Compare August 3, 2023 10:25
@Flouse Flouse requested review from KaoImin and removed request for Simon-Tl August 3, 2023 10:52
@driftluo driftluo force-pushed the reduce-mem-use-on-mod-exp branch from 110ee3c to a7b9835 Compare August 3, 2023 10:54
@KaoImin
Copy link
Copy Markdown
Contributor

KaoImin commented Aug 3, 2023

/run-ci

@axon-bot
Copy link
Copy Markdown

axon-bot Bot commented Aug 3, 2023

CI tests run on commit:

CI test list:

  • Code Format
  • Cargo Clippy

Please check ci test results later.

@driftluo driftluo force-pushed the reduce-mem-use-on-mod-exp branch 3 times, most recently from 79bee21 to bca7d33 Compare August 4, 2023 07:26
@driftluo driftluo force-pushed the reduce-mem-use-on-mod-exp branch from bca7d33 to 0c2c813 Compare August 4, 2023 07:27
@KaoImin KaoImin added this pull request to the merge queue Aug 4, 2023
Merged via the queue into main with commit bc7149f Aug 4, 2023
@driftluo driftluo deleted the reduce-mem-use-on-mod-exp branch August 4, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@felicityin felicityin Awaiting requested review from felicityin felicityin is a code owner automatically assigned from axonweb3/axon-dev

2 more reviewers

@blckngm blckngm blckngm approved these changes

@KaoImin KaoImin KaoImin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@driftluo driftluo

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@driftluo @KaoImin @blckngm