Skip to content

fix: update trie db key may delete#1245

Merged
KaoImin merged 2 commits intomainfrom
fix
Jul 3, 2023
Merged

fix: update trie db key may delete#1245
KaoImin merged 2 commits intomainfrom
fix

Conversation

@KaoImin
Copy link
Copy Markdown
Contributor

@KaoImin KaoImin commented Jun 29, 2023 •
edited
Loading

What this PR does / why we need it:

This PR fix a bug that update trie db of system contract may cause delete unexpectly.

Which issue(s) this PR fixes:

Fixes #

Which docs this PR relation:

Ref #

Which toolchain this PR adaption:

No Breaking Change

Special notes for your reviewer:

NIL

CI Description

CI Name Description
Chaos CI Test the liveness and robustness of Axon under terrible network condition
Cargo Clippy Run cargo clippy --all --all-targets --all-features
Coverage Test Get the unit test coverage report
E2E Test Run end-to-end test to check interfaces
Code Format Run cargo +nightly fmt --all -- --check and cargo sort -gwc
Web3 Compatible Test Test the Web3 compatibility of Axon
v3 Core Test Run the compatibility tests provided by Uniswap V3
OCT 1-5 | 6-10 | 11 | 12-15 | 16-19 Run the compatibility tests provided by OpenZeppelin

CI Usage

Check the CI you want to run below, and then comment /run-ci.

CI Switch

  • Chaos CI
  • Cargo Clippy
  • Coverage Test
  • E2E Tests
  • Code Format
  • Unit Tests
  • Web3 Compatible Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests

@KaoImin KaoImin requested a review from a team as a code owner June 29, 2023 16:39
@KaoImin KaoImin requested review from liya2017 and peterzhb June 29, 2023 16:39
@KaoImin KaoImin marked this pull request as draft June 29, 2023 16:39
@blckngm
Copy link
Copy Markdown
Contributor

blckngm commented Jun 30, 2023

Why don't we reuse RocksTrieDB from core_executor::adaptor::trie_db?

@KaoImin
Copy link
Copy Markdown
Contributor Author

KaoImin commented Jun 30, 2023

Why don't we reuse RocksTrieDB from core_executor::adaptor::trie_db?

Sounds good

@KaoImin KaoImin marked this pull request as ready for review July 3, 2023 03:32
@KaoImin
Copy link
Copy Markdown
Contributor Author

KaoImin commented Jul 3, 2023

/run-ci

@axon-bot
Copy link
Copy Markdown

axon-bot Bot commented Jul 3, 2023

CI tests run on commit:

CI test list:

  • Code Format
  • Cargo Clippy
  • Chaos CI
  • E2E Tests
  • Unit Tests
  • Web3 Compatible Tests

Please check ci test results later.

@KaoImin KaoImin added this pull request to the merge queue Jul 3, 2023
Merged via the queue into main with commit 9d204d4 Jul 3, 2023
@Flouse Flouse deleted the fix branch July 4, 2023 01:17
@liya2017 liya2017 mentioned this pull request Jul 12, 2023
Closed
KaoImin pushed a commit that referenced this pull request Sep 1, 2023
fix: update trie db key may delete (#1245)
8ce318b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peterzhb peterzhb Awaiting requested review from peterzhb peterzhb is a code owner automatically assigned from axonweb3/axon-dev

@liya2017 liya2017 Awaiting requested review from liya2017 liya2017 is a code owner automatically assigned from axonweb3/axon-dev

1 more reviewer

@blckngm blckngm blckngm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bugfix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@KaoImin @blckngm