fix: r/s should be quantities in json#1241
Merged
KaoImin merged 2 commits intoaxonweb3:mainfrom Jun 20, 2023
Merged
Conversation
KaoImin
reviewed
Jun 20, 2023
Co-authored-by: Eason Gao <[email protected]>
Contributor
|
/run-ci |
CI tests run on commit:
CI test list:
Please check ci test results later. |
KaoImin
approved these changes
Jun 20, 2023
This was referenced Jun 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
At least for eth sig, r/s should be quantities for spec conformance and better compatibility with various JSONRPC clients.
CI Description
cargo clippy --all --all-targets --all-featurescargo +nightly fmt --all -- --checkandcargo sort -gwcCI Usage
CI Switch