Skip to content

fix(API): update eth fee history rpc method#1206

Merged
KaoImin merged 2 commits intomainfrom
@michael/add_eth_feehistory
Jun 5, 2023
Merged

fix(API): update eth fee history rpc method#1206
KaoImin merged 2 commits intomainfrom
@michael/add_eth_feehistory

Conversation

@hongda3141
Copy link
Copy Markdown
Contributor

@hongda3141 hongda3141 commented May 25, 2023 •
edited
Loading

What this PR does / why we need it:

This PR update the RPC implement of eth_feeHistory.

Which issue(s) this PR fixes:

Fixes # #1106

Which docs this PR relation:

Ref #
https://docs.infura.io/infura/networks/ethereum/json-rpc-methods/eth_feehistory

Which toolchain this PR adaption:

No Breaking Change

Special notes for your reviewer:

NIL

CI Description

CI Name Description
Chaos CI Test the liveness and robustness of Axon under terrible network condition
Cargo Clippy Run cargo clippy --all --all-targets --all-features
Coverage Test Get the unit test coverage report
E2E Test Run end-to-end test to check interfaces
Code Format Run cargo +nightly fmt --all -- --check and cargo sort -gwc
Web3 Compatible Test Test the Web3 compatibility of Axon
v3 Core Test Run the compatibility tests provided by Uniswap V3
OCT 1-5 | 6-10 | 11 | 12-15 | 16-19 Run the compatibility tests provided by OpenZeppelin

CI Usage

Check the CI you want to run below, and then comment /run-ci.

CI Switch

  • Chaos CI
  • Cargo Clippy
  • Coverage Test
  • E2E Tests
  • Code Format
  • Unit Tests
  • Web3 Compatible Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests

@hongda3141 hongda3141 requested a review from a team as a code owner May 25, 2023 17:52
@hongda3141 hongda3141 requested review from felicityin and peterzhb May 25, 2023 17:52
@hongda3141
Copy link
Copy Markdown
Contributor Author

hongda3141 commented May 25, 2023

/run-ci

@axon-bot
Copy link
Copy Markdown

axon-bot Bot commented May 25, 2023

CI tests run on commit:

CI test list:

  • Code Format
  • Cargo Clippy
  • Chaos CI
  • Coverage Test
  • E2E Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • Unit Tests
  • v3 Core Tests
  • Web3 Compatible Tests

Please check ci test results later.

@hongda3141 hongda3141 changed the title fix(api): update eth_feehistory function fix(API): update eth fee history rpc method May 25, 2023
@hongda3141
Copy link
Copy Markdown
Contributor Author

hongda3141 commented May 28, 2023

/run-ci

@axon-bot
Copy link
Copy Markdown

axon-bot Bot commented May 28, 2023

CI tests run on commit:

CI test list:

  • Code Format
  • Cargo Clippy
  • Coverage Test
  • E2E Tests
  • Unit Tests

Please check ci test results later.

@hongda3141
Copy link
Copy Markdown
Contributor Author

hongda3141 commented May 28, 2023

/run-ci

@axon-bot
Copy link
Copy Markdown

axon-bot Bot commented May 28, 2023

CI tests run on commit:

CI test list:

  • E2E Tests

Please check ci test results later.

@hongda3141
Copy link
Copy Markdown
Contributor Author

hongda3141 commented May 28, 2023

/run-ci

@axon-bot
Copy link
Copy Markdown

axon-bot Bot commented May 28, 2023

CI tests run on commit:

CI test list:

  • E2E Tests

Please check ci test results later.

@hongda3141 hongda3141 force-pushed the @michael/add_eth_feehistory branch from 8ba5384 to 26aba73 Compare May 28, 2023 16:24
@hongda3141
Copy link
Copy Markdown
Contributor Author

hongda3141 commented May 28, 2023

/run-ci

@axon-bot
Copy link
Copy Markdown

axon-bot Bot commented May 28, 2023

CI tests run on commit:

CI test list:

  • Code Format
  • Cargo Clippy
  • Chaos CI
  • E2E Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • Unit Tests
  • v3 Core Tests
  • Web3 Compatible Tests

Please check ci test results later.

@hongda3141
Copy link
Copy Markdown
Contributor Author

hongda3141 commented May 28, 2023

/run-ci

@axon-bot
Copy link
Copy Markdown

axon-bot Bot commented May 28, 2023

CI tests run on commit:

CI test list:

  • Code Format
  • Cargo Clippy
  • Chaos CI
  • E2E Tests
  • Unit Tests

Please check ci test results later.

@hongda3141 hongda3141 force-pushed the @michael/add_eth_feehistory branch from 26aba73 to 45dddfc Compare June 1, 2023 04:20
@hongda3141
Copy link
Copy Markdown
Contributor Author

hongda3141 commented Jun 1, 2023

/run-ci

@axon-bot
Copy link
Copy Markdown

axon-bot Bot commented Jun 1, 2023

CI tests run on commit:

CI test list:

  • Code Format
  • Cargo Clippy
  • Chaos CI
  • E2E Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • Unit Tests
  • v3 Core Tests
  • Web3 Compatible Tests

Please check ci test results later.

michael added 2 commits June 2, 2023 07:14
feat: add eth_feeHistory function
d99a145 
feat: add usign type of block_count parameter

refactor: simply iter

doc: add function comments

test: update e2e test

test: update e2e test

test: update e2e test
fix: change gas_price from min to max
0d45e4f
@hongda3141 hongda3141 force-pushed the @michael/add_eth_feehistory branch from 24b2298 to 0d45e4f Compare June 1, 2023 23:14
@KaoImin KaoImin added this pull request to the merge queue Jun 5, 2023
Merged via the queue into main with commit dd629ee Jun 5, 2023
@KaoImin KaoImin deleted the @michael/add_eth_feehistory branch June 5, 2023 03:05
@KaoImin KaoImin mentioned this pull request Jul 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peterzhb peterzhb Awaiting requested review from peterzhb peterzhb is a code owner automatically assigned from axonweb3/axon-dev

@felicityin felicityin Awaiting requested review from felicityin felicityin is a code owner automatically assigned from axonweb3/axon-dev

1 more reviewer

@KaoImin KaoImin KaoImin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bugfix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hongda3141 @KaoImin