Skip to content

feat: random filter id#1203

Merged
KaoImin merged 1 commit intoaxonweb3:mainfrom
blckngm:random-filter-id
May 26, 2023
Merged

feat: random filter id#1203
KaoImin merged 1 commit intoaxonweb3:mainfrom
blckngm:random-filter-id

Conversation

@blckngm
Copy link
Copy Markdown
Contributor

@blckngm blckngm commented May 25, 2023 •
edited by KaoImin
Loading

What this PR does / why we need it:

Filter IDs must be unpredictable so filters can't be touched/uninstalled by other users.

And this makes it possible to sticky load balancing filter requests.

Which toolchain this PR adaption:

No Breaking Change

Special notes for your reviewer:

NIL

CI Description

CI Name Description
Chaos CI Test the liveness and robustness of Axon under terrible network condition
Cargo Clippy Run cargo clippy --all --all-targets --all-features
Coverage Test Get the unit test coverage report
E2E Test Run end-to-end test to check interfaces
Code Format Run cargo +nightly fmt --all -- --check and cargo sort -gwc
Web3 Compatible Test Test the Web3 compatibility of Axon
v3 Core Test Run the compatibility tests provided by Uniswap V3
OCT 1-5 | 6-10 | 11 | 12-15 | 16-19 Run the compatibility tests provided by OpenZeppelin

CI Usage

Check the CI you want to run below, and then comment /run-ci.

CI Switch

  • Chaos CI
  • Cargo Clippy
  • Coverage Test
  • E2E Tests
  • Code Format
  • Unit Tests
  • Web3 Compatible Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests

@blckngm blckngm requested a review from a team as a code owner May 25, 2023 05:28
@blckngm blckngm requested review from KaoImin and felicityin May 25, 2023 05:28
@KaoImin
Copy link
Copy Markdown
Contributor

KaoImin commented May 25, 2023

  1. rand is re-export from protocol::rand, it is useless to add to Cargo.toml.
  2. The id field in FilterHub struct seems useless, it should be removed.

@blckngm blckngm force-pushed the random-filter-id branch from c0bed0a to dfb97ec Compare May 25, 2023 08:55
@KaoImin
Copy link
Copy Markdown
Contributor

KaoImin commented May 26, 2023

/run-ci

@axon-bot
Copy link
Copy Markdown

axon-bot Bot commented May 26, 2023

CI tests run on commit:

CI test list:

  • Code Format
  • Cargo Clippy
  • E2E Tests
  • Unit Tests
  • Web3 Compatible Tests

Please check ci test results later.

@KaoImin
Copy link
Copy Markdown
Contributor

KaoImin commented May 26, 2023

@driftluo Please review it.

@KaoImin KaoImin added this pull request to the merge queue May 26, 2023
Merged via the queue into axonweb3:main with commit 35f9b77 May 26, 2023
@linnnsss linnnsss mentioned this pull request May 31, 2023
Closed
@blckngm blckngm deleted the random-filter-id branch June 20, 2023 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@driftluo driftluo driftluo approved these changes

@felicityin felicityin Awaiting requested review from felicityin felicityin is a code owner automatically assigned from axonweb3/axon-dev

+1 more reviewer

@KaoImin KaoImin KaoImin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@blckngm @KaoImin @driftluo