Conversation
Contributor
Author
|
/run-ci |
CI tests run on commit:
CI test list:
Please check ci test results later. |
ashuralyk
reviewed
May 10, 2023
| Ok(ret) | ||
| } | ||
|
|
||
| async fn get_proof_by_id(&self, block_id: BlockId) -> RpcResult<Option<Proof>> { |
Contributor
There was a problem hiding this comment.
is BlockId here hash or number?
Contributor
Author
There was a problem hiding this comment.
It can be either hash or number like this: https://github.com/axonweb3/axon/blob/main/core/api/src/jsonrpc/web3_types.rs#L359
| } | ||
|
|
||
| #[async_trait] | ||
| impl<Adapter: APIAdapter + 'static> AxonRpcServer for AxonRpcImpl<Adapter> { |
Contributor
There was a problem hiding this comment.
maybe miss one rpc to fetch validator_list?
KaoImin
changed the title
KaoImin
changed the title
hongda3141
approved these changes
May 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR add two axon exclusive rpc methods:
axon_getBlockById(BlockId)axon_getProofById(BlockId)Which issue(s) this PR fixes:
Fixes #
Which docs this PR relation:
Ref #
Which toolchain this PR adaption:
No Breaking Change
Special notes for your reviewer:
NIL
CI Description
cargo clippy --all --all-targets --all-featurescargo +nightly fmt --all -- --checkandcargo sort -gwcCI Usage
CI Switch