Skip to content

feat(executor): add block hook in system contract#1165

Merged
KaoImin merged 9 commits intomainfrom
system-contract-hook
May 16, 2023
Merged

feat(executor): add block hook in system contract#1165
KaoImin merged 9 commits intomainfrom
system-contract-hook

Conversation

@KaoImin
Copy link
Copy Markdown
Contributor

@KaoImin KaoImin commented Apr 27, 2023 •
edited
Loading

What this PR does / why we need it:

This PR add block hook for system contracts. The default implement is empty.

Which issue(s) this PR fixes:

Fixes #

Which docs this PR relation:

Ref #

Which toolchain this PR adaption:

No Breaking Change

Special notes for your reviewer:

NIL

CI Description

CI Name Description
Chaos CI Test the liveness and robustness of Axon under terrible network condition
Cargo Clippy Run cargo clippy --all --all-targets --all-features
Coverage Test Get the unit test coverage report
E2E Test Run end-to-end test to check interfaces
Code Format Run cargo +nightly fmt --all -- --check and cargo sort -gwc
Web3 Compatible Test Test the Web3 compatibility of Axon
v3 Core Test Run the compatibility tests provided by Uniswap V3
OCT 1-5 | 6-10 | 11 | 12-15 | 16-19 Run the compatibility tests provided by OpenZeppelin

CI Usage

Check the CI you want to run below, and then comment /run-ci.

CI Switch

  • Chaos CI
  • Cargo Clippy
  • Coverage Test
  • E2E Tests
  • Code Format
  • Unit Tests
  • Web3 Compatible Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests

@KaoImin KaoImin force-pushed the system-contract-hook branch from ffd8947 to 39223df Compare May 4, 2023 01:18
@KaoImin KaoImin force-pushed the system-contract-hook branch 2 times, most recently from 5070738 to 34d1ea4 Compare May 15, 2023 16:42
@KaoImin KaoImin marked this pull request as ready for review May 15, 2023 16:42
@KaoImin KaoImin requested a review from a team as a code owner May 15, 2023 16:42
@KaoImin KaoImin requested review from driftluo and wenyuanhust May 15, 2023 16:43
@KaoImin
Copy link
Copy Markdown
Contributor Author

KaoImin commented May 15, 2023

/run-ci

@axon-bot
Copy link
Copy Markdown

axon-bot Bot commented May 15, 2023

CI tests run on commit:

CI test list:

  • Code Format
  • Cargo Clippy
  • E2E Tests
  • OCT 1-5 And 12-15
  • Unit Tests
  • Web3 Compatible Tests

Please check ci test results later.

@KaoImin KaoImin force-pushed the system-contract-hook branch from 34d1ea4 to a57404d Compare May 16, 2023 02:42
@KaoImin KaoImin changed the title feat: add block hook in system contract feat(executor): add block hook in system contract May 16, 2023
@KaoImin
Copy link
Copy Markdown
Contributor Author

KaoImin commented May 16, 2023

/run-ci

@axon-bot
Copy link
Copy Markdown

axon-bot Bot commented May 16, 2023

CI tests run on commit:

CI test list:

  • Code Format
  • Cargo Clippy
  • E2E Tests
  • OCT 1-5 And 12-15
  • Unit Tests
  • Web3 Compatible Tests

Please check ci test results later.

wenyuanhust
wenyuanhust previously approved these changes May 16, 2023
View reviewed changes
@KaoImin KaoImin added this pull request to the merge queue May 16, 2023
Merged via the queue into main with commit 4021377 May 16, 2023
@KaoImin KaoImin deleted the system-contract-hook branch May 16, 2023 16:12
@Flouse Flouse added t:feature and removed feature labels Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@driftluo driftluo Awaiting requested review from driftluo driftluo is a code owner automatically assigned from axonweb3/axon-dev

2 more reviewers

@liya2017 liya2017 liya2017 approved these changes

@wenyuanhust wenyuanhust wenyuanhust left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

t:feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@KaoImin @wenyuanhust @liya2017 @Flouse