feat: add EIP-1898 blockHash option to JSON-RPC methods by ahonn · Pull Request #1101 · axonweb3/axon

ahonn · 2023-03-20T11:18:23Z

What this PR does / why we need it:

https://eips.ethereum.org/EIPS/eip-1898

Which issue(s) this PR fixes:

Fixes #

Which docs this PR relation:

Ref #

Which toolchain this PR adaption:

No Breaking Change

Special notes for your reviewer:

NIL

CI Description

CI Name	Description
Chaos CI	Test the liveness and robustness of Axon under terrible network condition
Cargo Clippy	Run `cargo clippy --all --all-targets --all-features`
Coverage Test	Get the unit test coverage report
E2E Test	Run end-to-end test to check interfaces
Code Format	Run `cargo +nightly fmt --all -- --check` and `cargo sort -gwc`
Web3 Compatible Test	Test the Web3 compatibility of Axon
v3 Core Test	Run the compatibility tests provided by Uniswap V3
OCT 1-5 \| 6-10 \| 11 \| 12-15 \| 16-19	Run the compatibility tests provided by OpenZeppelin

CI Usage

Check the CI you want to run below, and then comment /run-ci.

CI Switch

ahonn · 2023-03-20T13:00:59Z

/run-ci

axon-bot · 2023-03-20T13:01:20Z

CI tests run on commit:

commit id: 081e59d

CI test list:

Code Format
Cargo Clippy
Chaos CI
Coverage Test
E2E Tests
OCT 1-5 And 12-15
OCT 6-10
OCT 11
OCT 16-19
Unit Tests
v3 Core Tests
Web3 Compatible Tests

Please check ci test results later.

ahonn · 2023-03-21T03:51:36Z

/run-ci

axon-bot · 2023-03-21T03:51:57Z

CI tests run on commit:

commit id: 5587f19

CI test list:

Code Format
Cargo Clippy
E2E Tests
OCT 1-5 And 12-15
OCT 6-10
OCT 11
OCT 16-19
Unit Tests
v3 Core Tests
Web3 Compatible Tests

Please check ci test results later.

KaoImin

Only need to extend the BlockId enumeration like this:

#[derive(Default, Clone, Debug, PartialEq, Eq, Hash)]
pub enum BlockId {
    Num(u64),
    Hash(H256),
    #[default]
    Latest,
    Earliest,
    Pending,
}

ahonn · 2023-03-21T09:22:01Z

/run-ci

axon-bot · 2023-03-21T09:22:16Z

CI tests run on commit:

commit id: a05d11e

CI test list:

Code Format
Cargo Clippy
E2E Tests
OCT 1-5 And 12-15
OCT 6-10
OCT 11
OCT 16-19
Unit Tests
v3 Core Tests
Web3 Compatible Tests

Please check ci test results later.

ahonn · 2023-03-21T10:56:55Z

/run-ci

axon-bot · 2023-03-21T10:57:10Z

CI tests run on commit:

commit id: 0a484c2

CI test list:

Code Format
Cargo Clippy
E2E Tests
OCT 1-5 And 12-15
OCT 6-10
OCT 11
OCT 16-19
Unit Tests
v3 Core Tests
Web3 Compatible Tests

Please check ci test results later.

ahonn · 2023-03-21T13:32:41Z

/run-ci

axon-bot · 2023-03-21T13:33:02Z

CI tests run on commit:

commit id: 91df343

CI test list:

Code Format
Cargo Clippy
E2E Tests
OCT 1-5 And 12-15
OCT 6-10
OCT 11
OCT 16-19
Unit Tests
v3 Core Tests
Web3 Compatible Tests

Please check ci test results later.

ahonn · 2023-03-21T14:11:07Z

/run-ci

axon-bot · 2023-03-21T14:11:27Z

CI tests run on commit:

commit id: eab5ea2

CI test list:

Code Format
Cargo Clippy
E2E Tests
OCT 1-5 And 12-15
OCT 6-10
OCT 11
OCT 16-19
Unit Tests
v3 Core Tests
Web3 Compatible Tests

Please check ci test results later.

ahonn · 2023-03-21T18:33:43Z

/run-ci

axon-bot · 2023-03-21T18:34:05Z

CI tests run on commit:

commit id: 19b7c3d

CI test list:

Code Format
Cargo Clippy
E2E Tests
OCT 1-5 And 12-15
OCT 6-10
OCT 11
OCT 16-19
Unit Tests
v3 Core Tests
Web3 Compatible Tests

Please check ci test results later.

KaoImin

The type of Num in BlockID should be U64, the current code style is inelegant. It should be changed.

ahonn · 2023-03-22T08:09:16Z

/run-ci

axon-bot · 2023-03-22T08:09:35Z

CI tests run on commit:

commit id: a1884cb

CI test list:

Code Format
Cargo Clippy
E2E Tests
OCT 1-5 And 12-15
OCT 6-10
OCT 11
OCT 16-19
Unit Tests
v3 Core Tests
Web3 Compatible Tests

Please check ci test results later.

ahonn · 2023-03-22T10:03:34Z

/run-ci

axon-bot · 2023-03-22T10:03:50Z

CI tests run on commit:

commit id: 9217125

CI test list:

Code Format
Cargo Clippy
E2E Tests
OCT 1-5 And 12-15
OCT 6-10
OCT 11
OCT 16-19
Unit Tests
v3 Core Tests
Web3 Compatible Tests

Please check ci test results later.

ahonn requested a review from a team as a code owner March 20, 2023 11:18

ahonn requested review from hongda3141 and wenyuanhust March 20, 2023 11:18

github-actions Bot added the feature label Mar 20, 2023

KaoImin changed the title ~~[WIP] feat: add EIP-1898 blockHash option to JSON-RPC methods~~ [WIP] feat: add EIP-1898 blockHash option to JSON-RPC methods Mar 20, 2023

KaoImin suggested changes Mar 21, 2023

View reviewed changes

Comment thread core/api/src/jsonrpc/web3_types.rs Outdated

feat: add BlockId::Hash and update rpc methods

a05d11e

ahonn force-pushed the feature/eip-1898 branch from 01e4939 to a05d11e Compare March 21, 2023 09:15

refactor: add get_block_number_by_id

6c4fb71

KaoImin requested a review from driftluo March 21, 2023 10:53

Merge branch 'main' into feature/eip-1898

0a484c2

style: fix code format issues

eab5ea2

ahonn force-pushed the feature/eip-1898 branch from 91df343 to eab5ea2 Compare March 21, 2023 14:10

test: add more eth_getStorageAt e2e test

19b7c3d

ahonn changed the title ~~[WIP] feat: add EIP-1898 blockHash option to JSON-RPC methods~~ feat: add EIP-1898 blockHash option to JSON-RPC methods Mar 22, 2023

KaoImin reviewed Mar 22, 2023

View reviewed changes

Comment thread core/api/src/jsonrpc/web3_types.rs Outdated

Comment thread core/api/src/jsonrpc/web3_types.rs Outdated

ahonn force-pushed the feature/eip-1898 branch from dfedeb2 to 19b7c3d Compare March 22, 2023 07:39

refactor: change BlockId::Num(u64) to U64

a1884cb

KaoImin previously approved these changes Mar 22, 2023

View reviewed changes

KaoImin reviewed Mar 22, 2023

View reviewed changes

Comment thread core/api/src/adapter.rs Outdated

style: fix cargo clippy issue

903670f

ahonn dismissed KaoImin’s stale review via 903670f March 22, 2023 09:50

ahonn added 2 commits March 22, 2023 17:58

feat: remove useless get_block_header_by_hash

e7306b8

Merge branch 'main' into feature/eip-1898

9217125

KaoImin approved these changes Mar 22, 2023

View reviewed changes

ahonn added this pull request to the merge queue Mar 22, 2023

ahonn merged commit 98a8216 into main Mar 22, 2023

KaoImin deleted the feature/eip-1898 branch March 22, 2023 16:38

wenyuanhust mentioned this pull request Apr 8, 2023

Axon Development Updates 04/05/2023 #1143

Closed

KaoImin mentioned this pull request Apr 21, 2023

Consider implementing EIP-1898 (blockHash to defaultBlock of eth_call) #1155

Closed

Flouse added t:feature and removed feature labels Nov 17, 2023

Conversation

ahonn commented Mar 20, 2023 • edited by KaoImin Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ahonn commented Mar 20, 2023

Uh oh!

axon-bot Bot commented Mar 20, 2023

CI tests run on commit:

CI test list:

Please check ci test results later.

Uh oh!

ahonn commented Mar 21, 2023

Uh oh!

axon-bot Bot commented Mar 21, 2023

CI tests run on commit:

CI test list:

Please check ci test results later.

Uh oh!

KaoImin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ahonn commented Mar 21, 2023

Uh oh!

axon-bot Bot commented Mar 21, 2023

CI tests run on commit:

CI test list:

Please check ci test results later.

Uh oh!

ahonn commented Mar 21, 2023

Uh oh!

axon-bot Bot commented Mar 21, 2023

CI tests run on commit:

CI test list:

Please check ci test results later.

Uh oh!

ahonn commented Mar 21, 2023

Uh oh!

axon-bot Bot commented Mar 21, 2023

CI tests run on commit:

CI test list:

Please check ci test results later.

Uh oh!

ahonn commented Mar 21, 2023

Uh oh!

axon-bot Bot commented Mar 21, 2023

CI tests run on commit:

CI test list:

Please check ci test results later.

Uh oh!

ahonn commented Mar 21, 2023

Uh oh!

axon-bot Bot commented Mar 21, 2023

CI tests run on commit:

CI test list:

Please check ci test results later.

Uh oh!

KaoImin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ahonn commented Mar 22, 2023

Uh oh!

axon-bot Bot commented Mar 22, 2023

CI tests run on commit:

CI test list:

Please check ci test results later.

Uh oh!

Uh oh!

ahonn commented Mar 22, 2023

Uh oh!

axon-bot Bot commented Mar 22, 2023

CI tests run on commit:

CI test list:

Please check ci test results later.

Uh oh!

Reviewers

Assignees

Labels

ahonn commented Mar 20, 2023 •

edited by KaoImin

Loading