logsource: make an aggregate input_window_full_total metric available on stats-level(1)#938
Conversation
This patch will allow labels to be overridden by subsequent options in the key-builder stack. It's always the "first" value that overrides any subsequent ones. This also allows the removal of a label, by specifying the empty string as a value. Signed-off-by: Balazs Scheidler <[email protected]>
…er stats-levels On stats-levels(2), we won't need connection level details on the "window-full" counter, so let's create a shared metric that will not have the "peer_address" or "connection" labels. This means that this is an aggregate of window-full events across all of the connections of a specific driver. Signed-off-by: Balazs Scheidler <[email protected]>
|
We found issues related to this counter when they were aggregated; I don't remember the exact details, @mitzkia might remember. We should probably check all call-sites and make sure we don't call |
MrAnno
left a comment
MrAnno
left a comment
There was a problem hiding this comment.
We should get rid of set() calls if we want to aggregate these counters because they will overwrite each other's values.
If you mean these set() calls: Then these are never applied to "shared" counters, as neither the capacity nor the window_available metrics are available below stats-level(4) and on those levels these metrics are connection specific. Let me know if you disagree. |
MrAnno
left a comment
MrAnno
left a comment
There was a problem hiding this comment.
Everything is fine then. Sorry for the confusion
2 participants
Window related metrics are a debugging measure, so they have been available on stats-level(4), however the aggregate
of window-full events is interesting even on lower levels and a single time series is worth it to have it always available.
So this patch adds the ability to mask (or whiteout) a label from a StatsClusterKeyBuilder, so the associated logic can be
implemented in logsource.