Fix parsing JSON array of string with comma#923
Merged
bazsi merged 2 commits intoaxoflow:mainfrom Jan 22, 2026
Merged
Conversation
When a JSON array is parsed, a string value containing a comma and no single or double quote is kept as-is and added to a list. The comma being a delimiter for list items, when the list is serialized to JSON again, that comma is not treated as a part of the original string, but as a separator: ``` ["a", "b", "c,d"] -> "a,b,c,d" ["a", "b", "c", "d"] <- "a,b,c,d" ``` Add the comma to the list of forbidden chars in a string to force quoting of the value, preventing this bug: ``` ["a", "b", "c,d"] -> "a,b,\"c,d\"" ["a", "b", "c,d"] <- "a,b,\"c,d\"" ``` Signed-off-by: Romain Tartière <[email protected]>
Signed-off-by: László Várady <[email protected]>
bazsi
approved these changes
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nice catch by @smortex
Cherry-picked from syslog-ng/syslog-ng#5604