scanner/kv-scanner: fix updating cursor position#921
Merged
MrAnno merged 4 commits intoaxoflow:mainfrom Jan 23, 2026
Merged
Conversation
bazsi
reviewed
Jan 22, 2026
bazsi
previously approved these changes
Jan 22, 2026
Before the fix the new (improperly quoted) kv pair in the value field would overwrite the original, proper one. Signed-off-by: Szilard Parrag <[email protected]>
Signed-off-by: Szilard Parrag <[email protected]>
Signed-off-by: Szilard Parrag <[email protected]>
OverOrion
force-pushed
the
fix/kv-scanner-improper-quote-overwriting-kv
branch
from
7f94de5 to
15d7c3f
Compare
Signed-off-by: Szilard Parrag <[email protected]>
MrAnno
approved these changes
Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO:
The cursor position was not updated if it encountered a quoting error, resulting in overwriting previous key-value pair.