Fix backtick subst in multi-line SCL block args#920
Merged
OverOrion merged 7 commits intoaxoflow:mainfrom Jan 22, 2026
Merged
Conversation
MrAnno
added a commit
to MrAnno/axosyslog
that referenced
this pull request
Jan 21, 2026
Signed-off-by: László Várady <[email protected]>
bazsi
reviewed
Jan 22, 2026
Member
bazsi
left a comment
bazsi
left a comment
There was a problem hiding this comment.
I did check if the suspend_input, resume_input patch was equivalent, and I found that all cases where we exit the block state, we call resume, so that's a check.
we now have three ways to lex block and function arguments:
- block_param: when we are parsing the parameter list for blocks?
- block_arg: when we are invoking the block and passing the value
- func_arg: when we are invoking a block in filterx and is more like a function call
These names are not used consistently everywhere, so I'd add some comments, but otherwise I did not find functional issues, great job.
Contributor
Author
|
Thank you. Yes, parameters are for declaration, args are the actual passed values, which we currently have 2 flavors of. |
bazsi
reviewed
Jan 22, 2026
bazsi
reviewed
Jan 22, 2026
Member
|
that's all, I had a 3rd comment, but that was invalid. |
It modifies the input, so "filter" is no longer the correct name. Signed-off-by: László Várady <[email protected]>
This is a refactor (equivalent transformation) and preparation for fixing a backtick subst bug. Signed-off-by: László Várady <[email protected]>
Signed-off-by: László Várady <[email protected]>
This fixes a bug where global backtick substitution didn't work in SCL arguments in case those arguments were spread across multiple lines. Signed-off-by: László Várady <[email protected]>
Signed-off-by: László Várady <[email protected]>
MrAnno
force-pushed
the
fix-backticksubst-in-args
branch
from
e400703 to
9a2601d
Compare
Signed-off-by: László Várady <[email protected]>
Signed-off-by: László Várady <[email protected]>
MrAnno
force-pushed
the
fix-backticksubst-in-args
branch
from
9a2601d to
d2eeb66
Compare
OverOrion
approved these changes
Jan 22, 2026
Contributor
OverOrion
left a comment
OverOrion
left a comment
There was a problem hiding this comment.
Thank you, your atomic commits really helped with the review! ⚛️ 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug where global backtick substitution didn't work in SCL arguments in case those arguments were spread across multiple lines.
Reviewers please check if commit
cfg-lexer: suspend input subst explicitly for blocks and argsis truly an equivalent transformation.Reproducer (check the output of preprocess-into):