Skip to content

http: add force-content-compression toggle#916

Merged
MrAnno merged 4 commits intoaxoflow:mainfrom
OverOrion:feat/force-compression-toggle
Jan 20, 2026
Merged

http: add force-content-compression toggle#916
MrAnno merged 4 commits intoaxoflow:mainfrom
OverOrion:feat/force-compression-toggle

Conversation

@OverOrion
Copy link
Contributor

@OverOrion OverOrion commented Jan 19, 2026

This PR adds a new option force-content-compression(<yesno>) for http destination drivers.
The new option allows one to force compression, even if the resulting payload size is larger than before compression.
Although rarely, but it can happen with short messages, and some destinations expect always compressed payload.

This fixes an issue where destinations expect compressed payload,
but we did not send due to size concerns.

Signed-off-by: Szilard Parrag <[email protected]>
Signed-off-by: Szilard Parrag <[email protected]>
@github-actions
Copy link
Contributor

This Pull Request introduces config grammar changes

axoflow/a17f6a8f3334da5104460a2fe465b15540656a21 -> OverOrion/feat/force-compression-toggle

Details
--- a/destination
+++ b/destination

 http(
+    force-content-compression(<yesno>)
 )

@OverOrion OverOrion marked this pull request as ready for review January 19, 2026 14:40
MrAnno
MrAnno previously approved these changes Jan 19, 2026
bazsi
bazsi previously approved these changes Jan 20, 2026
Copy link
Member

@bazsi bazsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@OverOrion OverOrion self-assigned this Jan 20, 2026
@MrAnno
Copy link
Contributor

MrAnno commented Jan 20, 2026

We'll need a news entry and we can merge this.

@OverOrion OverOrion dismissed stale reviews from bazsi and MrAnno via bd82f22 January 20, 2026 16:23
@OverOrion
Copy link
Contributor Author

I thought I pushed the commit, sorry, it was a local patch only.

@OverOrion OverOrion requested a review from MrAnno January 20, 2026 16:23
@MrAnno
Copy link
Contributor

MrAnno commented Jan 20, 2026

We might want to mention it later that this is needed because compression is not applied under certain circumstances (size would increase, other errors)

@MrAnno MrAnno merged commit 54416fb into axoflow:main Jan 20, 2026
21 of 22 checks passed
fekete-robert pushed a commit to axoflow/axosyslog-core-docs that referenced this pull request Feb 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants