Disk buffer abandoned disk-buffer-metrics#902
Merged
MrAnno merged 1 commit intoaxoflow:mainfrom Jan 19, 2026
Merged
Conversation
bshifter
force-pushed
the
disk-buffer-abandoned-disk-metrics
branch
from
dbc2863 to
66a9232
Compare
bshifter
changed the title
MrAnno
reviewed
Jan 15, 2026
MrAnno
reviewed
Jan 15, 2026
bshifter
force-pushed
the
disk-buffer-abandoned-disk-metrics
branch
2 times, most recently
from
90a8fb8 to
644cf91
Compare
Contributor
bazsi
reviewed
Jan 15, 2026
bshifter
force-pushed
the
disk-buffer-abandoned-disk-metrics
branch
2 times, most recently
from
6f2ae1c to
7a7dd77
Compare
MrAnno
reviewed
Jan 16, 2026
MrAnno
previously approved these changes
Jan 16, 2026
bshifter
dismissed
MrAnno’s stale review
The merge-base changed after approval.
…ds header only Signed-off-by: shifter <[email protected]>
bshifter
force-pushed
the
disk-buffer-abandoned-disk-metrics
branch
from
7a7dd77 to
ae40ddf
Compare
MrAnno
approved these changes
Jan 16, 2026
Contributor
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, abandoned disk buffer metrics were calculated by loading the entire buffer file, which could significantly impact reload times. This change avoids loading the full disk-buffer contents by using the information already available in the file header, which is sufficient to compute the required metrics.
Depends on #912