Merged
Conversation
bazsi
force-pushed
the
filterx-movable-refs
branch
from
bcfc36a to
f36a71d
Compare
bazsi
force-pushed
the
filterx-movable-refs
branch
from
f36a71d to
1fafa82
Compare
bazsi
force-pushed
the
filterx-movable-refs
branch
from
1fafa82 to
00ff085
Compare
bazsi
force-pushed
the
filterx-movable-refs
branch
3 times, most recently
from
3aec442 to
810d6f8
Compare
Signed-off-by: Balazs Scheidler <[email protected]>
Instead of naming xrefs floating by convention, make it explicit with a flag and associated functions. xrefs can be floated using `filterx_ref_float()` and grounded using `filterx_ref_ground()`. Once an xref is floating, it can be converted into a grounded xref without doing a clone operation. Signed-off-by: Balazs Scheidler <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]>
bazsi
force-pushed
the
filterx-movable-refs
branch
from
810d6f8 to
4217ea7
Compare
MrAnno
approved these changes
Feb 12, 2026
fekete-robert
pushed a commit
to axoflow/axosyslog-core-docs
that referenced
this pull request
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements move() as a syntax as well as the backing code to handle "floating" FilterXRef references.
An example config:
This basically unsets the
dvariable and moves it in its entirety into d2, avoiding a copy (and copy-on-write as well!).NOTE: This contains some of the same object-dict refactoring patches as #869, whichever goes in first, this works. They can also be dropped using a rebase, or we can merge those separately by extracting them into their own PR.