filterx/expr-variable: fix assignment tracking for unmarshalled variables#849
Merged
alltilla merged 1 commit intoaxoflow:mainfrom Nov 13, 2025
Conversation
…bles
If a just assigned variable is unmarshalled in place, the "assigned"
value was always set to FALSE, even if it was originally TRUE. This means
that these variables were to synced to the message at the end of
the filterx block.
Here's an example:
$foo = $PROGRAM;
if ($foo === "whatever") {
}
The condition unmarshalls the value, causing the "assigned" value for $foo
to be set to FALSE.
This means that filterx_scope_sync() will not write this value to
the message.
Signed-off-by: Balazs Scheidler <[email protected]>
bazsi
changed the title
alltilla
approved these changes
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a just assigned variable is unmarshalled in place, the "assigned" value was always set to FALSE, even if it was originally TRUE. This means that these variables were not synced to the message at the end of the filterx block.
Here's an example:
The condition unmarshalls the value, causing the "assigned" value for $foo to be set to FALSE.
This means that filterx_scope_sync() will not write this value to the message.