Merged
Conversation
For a large configuration, parsing the config can take 3 seconds and 75% of that is spent in the plugin lookup function. Signed-off-by: Balazs Scheidler <[email protected]>
The printf() family of functions is slow, compared to doing just the equivalent string operations. Signed-off-by: Balazs Scheidler <[email protected]>
MrAnno
reviewed
Nov 11, 2025
We are not actually copying the plugin list, we just share the hash table. Signed-off-by: Balazs Scheidler <[email protected]>
alltilla
approved these changes
Nov 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This gives us roughly 4x increase in config load performance (0.7sec instead of 3 on my test config, which preprocesses into 500k lines).