opentelemetry(), threaded sources: add keep-alive()#832
Merged
alltilla merged 14 commits intoaxoflow:mainfrom Nov 4, 2025
Merged
opentelemetry(), threaded sources: add keep-alive()#832alltilla merged 14 commits intoaxoflow:mainfrom
opentelemetry(), threaded sources: add keep-alive()#832alltilla merged 14 commits intoaxoflow:mainfrom
Conversation
Contributor
This Pull Request introduces config grammar changesaxoflow/dbce1fa120dd260978a2204300cee3b96c0f00cb -> MrAnno/otel-src-keep-alive Details--- a/source
+++ b/source
axosyslog-otlp(
+ keep-alive(<yesno>)
)
opentelemetry(
+ keep-alive(<yesno>)
)
syslog-ng-otlp(
+ keep-alive(<yesno>)
)
|
MrAnno
force-pushed
the
otel-src-keep-alive
branch
from
30d34be to
4b2231f
Compare
Member
|
I have reviewed with the core changes, but the Otel/grpc related C++ code reads Chinese to me. |
MrAnno
force-pushed
the
otel-src-keep-alive
branch
from
4b2231f to
27245a5
Compare
Contributor
Author
|
@bazsi Thank you. |
MrAnno
added a commit
to MrAnno/axosyslog
that referenced
this pull request
Oct 27, 2025
Signed-off-by: László Várady <[email protected]>
MrAnno
added a commit
to MrAnno/axosyslog
that referenced
this pull request
Oct 27, 2025
Signed-off-by: László Várady <[email protected]>
MrAnno
force-pushed
the
otel-src-keep-alive
branch
from
4742272 to
bdd25c6
Compare
Signed-off-by: László Várady <[email protected]>
Signed-off-by: László Várady <[email protected]>
It is needed in derived classes during the implementation of the keep alive mechanism. Signed-off-by: László Várady <[email protected]>
Workers are scaled up or down depending on the new configuration. Signed-off-by: László Várady <[email protected]>
The driver is accessible from the worker through LogThreadedSourceWorker::control. The more places we cache this reference, the more places we have to update it during reload. Signed-off-by: László Várady <[email protected]>
Signed-off-by: László Várady <[email protected]>
Signed-off-by: László Várady <[email protected]>
Signed-off-by: László Várady <[email protected]>
This is needed to stop the worker thread without shutting down the server or completion queue. Signed-off-by: László Várady <[email protected]>
Signed-off-by: László Várady <[email protected]>
Signed-off-by: László Várady <[email protected]>
Signed-off-by: László Várady <[email protected]>
Signed-off-by: László Várady <[email protected]>
Signed-off-by: László Várady <[email protected]>
MrAnno
force-pushed
the
otel-src-keep-alive
branch
from
bdd25c6 to
ddd24a9
Compare
sodomelle
approved these changes
Oct 29, 2025
Contributor
sodomelle
left a comment
sodomelle
left a comment
There was a problem hiding this comment.
As far as I can tell, it looks good.
alltilla
approved these changes
Nov 4, 2025
Member
alltilla
left a comment
alltilla
left a comment
There was a problem hiding this comment.
Haven't tried it out yet, if someone did, feel free to merge, otherwise I will do another round of review with trying it out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #831
TODO: