Merged
Conversation
bazsi
force-pushed
the
log-source-window-stats
branch
2 times, most recently
from
02f5d60 to
57df261
Compare
Sometimes keys are not registered, e.g. their value will be NULL, just accept that in the destructor, making the call-sites a lot neater. This is not performance critical anyway. Signed-off-by: Balazs Scheidler <[email protected]>
…cinity. Signed-off-by: Balazs Scheidler <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]>
…etric The legacy counter is gone (has always been on an undocumented stats-level(4)). This renames the counter as well as applies the same labels as other similar metrics. Signed-off-by: Balazs Scheidler <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]>
…unregister function There's no point in having only this a separate function. Signed-off-by: Balazs Scheidler <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]>
bazsi
force-pushed
the
log-source-window-stats
branch
from
57df261 to
c757651
Compare
Merged
alltilla
approved these changes
Oct 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR turns window related stat counters into Prometheus style metrics and also adds the window_full_total metric to
count the number of cases where the input window is full.