Merged
Conversation
Signed-off-by: László Várady <[email protected]>
MrAnno
force-pushed
the
fix-otel-lifetime
branch
from
99f7c52 to
5fbbfa4
Compare
The queues must be drained, even when workers are not started at all. Signed-off-by: László Várady <[email protected]>
It belongs to the worker. Signed-off-by: László Várady <[email protected]>
MrAnno
force-pushed
the
fix-otel-lifetime
branch
from
5fbbfa4 to
34ffd15
Compare
Signed-off-by: László Várady <[email protected]>
Unfortunately, the server's lifetime depends on other source-specific fields, so it can't be abstracted into the gRPC class. Signed-off-by: László Várady <[email protected]>
Contributor
Author
|
According to the gRPC docs, the completion queues should always be drained. We only did that within the worker thread, but in case of config failures during reload, the thread is not started, causing the crashes. |
bshifter
approved these changes
Oct 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #264
Fixes #316
I'll write a news entry in #820.