HAProxy g_assert_not_reached() fix#814
Merged
OverOrion merged 4 commits intoaxoflow:mainfrom Oct 9, 2025
Merged
Conversation
bazsi
added a commit
to bazsi/axosyslog
that referenced
this pull request
Oct 3, 2025
Signed-off-by: Balazs Scheidler <[email protected]>
bazsi
added a commit
to bazsi/axosyslog
that referenced
this pull request
Oct 3, 2025
Signed-off-by: Balazs Scheidler <[email protected]>
bazsi
force-pushed
the
haproxy-abort-fix
branch
from
090cf46 to
f67297e
Compare
Member
Author
|
Apart from fixing the abort, this PR also does the following:
The minimal fix continues to be the first patch. |
…ions LOCAL connections have no address information, so don't make an attempt at extracting it. Signed-off-by: Balazs Scheidler <[email protected]>
It is better to just accept our fate and not parse the addresses from the header than to crash. Signed-off-by: Balazs Scheidler <[email protected]>
UNKNOWN (PROXYv1) or LOCAL (PROXYv2) connections serve a health-check purpose, so drop them without an error message. Signed-off-by: Balazs Scheidler <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]>
bazsi
force-pushed
the
haproxy-abort-fix
branch
from
f67297e to
b95bbcf
Compare
OverOrion
approved these changes
Oct 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks @Damianv99 for the detailed error report in syslog-ng/syslog-ng#5516.
Since I merged that code originally into syslog-ng, I feel responsible for fixing it too. As we've forked syslog-ng, this PR is against the fork, AxoSyslog.
The minimal fix is only the first patch (a1f5b91), if you want to apply it locally, you are welcome to.
It should be merged into AxoSyslog after review, which should be pretty soon, as this is a trivial DoS attack, if the haproxy protocol is enabled.