network(), syslog(): Fixed a potential crash for TLS destinations during reload#418
Merged
MrAnno merged 14 commits intoaxoflow:mainfrom Dec 19, 2024
Merged
network(), syslog(): Fixed a potential crash for TLS destinations during reload#418MrAnno merged 14 commits intoaxoflow:mainfrom
network(), syslog(): Fixed a potential crash for TLS destinations during reload#418MrAnno merged 14 commits intoaxoflow:mainfrom
Conversation
sodomelle
added a commit
to sodomelle/axosyslog
that referenced
this pull request
Dec 16, 2024
Signed-off-by: Tamás Kosztyu <[email protected]>
sodomelle
force-pushed
the
tls-destination-crash
branch
from
fe77161 to
876423b
Compare
sodomelle
added a commit
to sodomelle/axosyslog
that referenced
this pull request
Dec 16, 2024
Signed-off-by: Tamás Kosztyu <[email protected]>
sodomelle
force-pushed
the
tls-destination-crash
branch
from
876423b to
d6e22e8
Compare
sodomelle
added a commit
to sodomelle/axosyslog
that referenced
this pull request
Dec 16, 2024
Signed-off-by: Tamás Kosztyu <[email protected]>
sodomelle
force-pushed
the
tls-destination-crash
branch
from
d6e22e8 to
223da2c
Compare
sodomelle
added a commit
to sodomelle/axosyslog
that referenced
this pull request
Dec 16, 2024
Signed-off-by: Tamás Kosztyu <[email protected]>
sodomelle
force-pushed
the
tls-destination-crash
branch
from
223da2c to
0dea14b
Compare
mitzkia
reviewed
Dec 16, 2024
Contributor
mitzkia
left a comment
mitzkia
left a comment
There was a problem hiding this comment.
Thanks a lot for the Light feature update and a new testcase.
I have added some review notes.
...t/functional_tests/destination_drivers/network_destination/test_tls_verifier_reload_crash.py
Outdated
Show resolved
Hide resolved
...t/functional_tests/destination_drivers/network_destination/test_tls_verifier_reload_crash.py
Outdated
Show resolved
Hide resolved
sodomelle
added a commit
to sodomelle/axosyslog
that referenced
this pull request
Dec 16, 2024
Signed-off-by: Tamás Kosztyu <[email protected]>
sodomelle
force-pushed
the
tls-destination-crash
branch
from
0dea14b to
24567d0
Compare
sodomelle
added a commit
to sodomelle/axosyslog
that referenced
this pull request
Dec 16, 2024
Signed-off-by: Tamás Kosztyu <[email protected]>
sodomelle
force-pushed
the
tls-destination-crash
branch
from
24567d0 to
4f3d2fb
Compare
sodomelle
added a commit
to sodomelle/axosyslog
that referenced
this pull request
Dec 16, 2024
Signed-off-by: Tamás Kosztyu <[email protected]>
sodomelle
force-pushed
the
tls-destination-crash
branch
from
4f3d2fb to
fec4647
Compare
bazsi
reviewed
Dec 16, 2024
bazsi
reviewed
Dec 16, 2024
bazsi
reviewed
Dec 16, 2024
bazsi
reviewed
Dec 16, 2024
MrAnno
pushed a commit
to MrAnno/axosyslog
that referenced
this pull request
Dec 18, 2024
Signed-off-by: Tamás Kosztyu <[email protected]>
MrAnno
force-pushed
the
tls-destination-crash
branch
from
fec4647 to
0f831f4
Compare
Signed-off-by: László Várady <[email protected]>
Signed-off-by: Tamás Kosztyu <[email protected]> Signed-off-by: László Várady <[email protected]>
Signed-off-by: László Várady <[email protected]>
Signed-off-by: Tamás Kosztyu <[email protected]>
Signed-off-by: Tamás Kosztyu <[email protected]>
Signed-off-by: Tamás Kosztyu <[email protected]> Signed-off-by: László Várady <[email protected]>
Signed-off-by: Tamás Kosztyu <[email protected]>
Signed-off-by: László Várady <[email protected]> Signed-off-by: Tamás Kosztyu <[email protected]>
It is possible to keep TLS connections alive during reload. In that case the LogWriter instance is persisted in cfg persist. This LogWriter's signal slot connector wasn't updated based on the new configuration, which could cause a crash. The signal slot connector is updated, so the newly configured verifier is used, instead of the old one. Signed-off-by: Tamás Kosztyu <[email protected]>
Signed-off-by: Tamás Kosztyu <[email protected]>
Signed-off-by: László Várady <[email protected]>
Signed-off-by: László Várady <[email protected]>
MrAnno
force-pushed
the
tls-destination-crash
branch
from
0f831f4 to
23b3c5b
Compare
Signed-off-by: László Várady <[email protected]>
Signed-off-by: László Várady <[email protected]>
MrAnno
force-pushed
the
tls-destination-crash
branch
from
23b3c5b to
4648b61
Compare
Contributor
|
The |
bazsi
reviewed
Dec 19, 2024
| TLSSession * | ||
| log_tansport_tls_get_session(LogTransport *s) | ||
| { | ||
| g_assert(s->name == TLS_TRANSPORT_NAME); |
Member
There was a problem hiding this comment.
nitpick: I don't think C compilers will always ensure that the pointer value of a literal string expression is always the same. I would have used the address of one of the private methods instead.
Contributor
There was a problem hiding this comment.
We wanted something that will less likely change if we happen to inherit from the TLS clss.
Using the address of a globally declared const gchar *a = "static" and const gchar a[] = "static" should be safe and consistent in C99.
Contributor
There was a problem hiding this comment.
Due to the forced merge requirements, I have to "resolve" this comment to merge the PR.
Though I still don't agree with such routine, I'm clicking on "resolve".
bazsi
approved these changes
Dec 19, 2024
Member
bazsi
left a comment
bazsi
left a comment
There was a problem hiding this comment.
I only have one nitpick but this can go in without fixing that.
mitzkia
approved these changes
Dec 19, 2024
Contributor
mitzkia
left a comment
mitzkia
left a comment
There was a problem hiding this comment.
Thanks for the Light part of the update, it is approved from my side.
MrAnno
approved these changes
Dec 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes syslog-ng/syslog-ng#5018
It is possible to keep TLS connections alive during reload.
In that case the LogWriter instance is persisted in cfg persist.
This LogWriter's signal slot connector wasn't updated based on the new configuration, which could cause a crash.
The signal slot connector is updated, so the newly configured verifier is used, instead of the old one.
Note that the fix in syslog-ng/syslog-ng#5087 has a security issue, as in that PR, the connector's lifetime is extended, but the verifier plugins are deregistered during reload, which silently disables all TLS verifiers without the user knowing.