s3: workaround on-reload memleak when no role is set#318
Merged
alltilla merged 1 commit intoaxoflow:mainfrom Oct 2, 2024
Merged
s3: workaround on-reload memleak when no role is set#318alltilla merged 1 commit intoaxoflow:mainfrom
alltilla merged 1 commit intoaxoflow:mainfrom
Conversation
alltilla
reviewed
Oct 1, 2024
Member
alltilla
left a comment
alltilla
left a comment
There was a problem hiding this comment.
Thanks for the fix! :)
Please git commit --amend -s. Otherwise approve.
AxoSyslog leaks an amount of memory every time it's reloaded if an s3 destination is configured. As a quick workaround we partially revert the patch introducing the use of `boto3.Session` when no `role()` is set. Signed-off-by: Mate Ory <[email protected]>
orymate
force-pushed
the
s3-memleak-workaround
branch
from
22f143a to
8215551
Compare
Member
|
A comment would probably be worth to explain the scenario when a session could leak memory in case of frequent reloads. |
alltilla
approved these changes
Oct 2, 2024
alltilla
added a commit
to alltilla/axosyslog
that referenced
this pull request
Oct 2, 2024
Signed-off-by: Attila Szakacs <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AxoSyslog leaks an amount of memory every time it's reloaded if an s3
destination is configured (#317). As a quick workaround we partially revert the
patch introducing the use of
boto3.Sessionwhen norole()is set.