file(), stdout(): fix log sources getting stuck#303
Merged
alltilla merged 7 commits intoaxoflow:mainfrom Sep 24, 2024
Merged
Conversation
MrAnno
added a commit
to MrAnno/axosyslog
that referenced
this pull request
Sep 22, 2024
Signed-off-by: László Várady <[email protected]>
MrAnno
changed the title
file(), stdout(): fix log sources getting stuck
MrAnno
added a commit
to MrAnno/axosyslog
that referenced
this pull request
Sep 22, 2024
Signed-off-by: László Várady <[email protected]>
MrAnno
force-pushed
the
fix-file-writer-proto
branch
from
23d2438 to
9614d74
Compare
alltilla
approved these changes
Sep 24, 2024
Member
alltilla
left a comment
alltilla
left a comment
There was a problem hiding this comment.
Awesome!
I had one small comment which you can ignore.
Signed-off-by: László Várady <[email protected]>
Signed-off-by: László Várady <[email protected]>
Signed-off-by: László Várady <[email protected]>
Signed-off-by: László Várady <[email protected]>
Signed-off-by: László Várady <[email protected]>
If a partial write occurs, the written messages must be acknowledged. It is important to note that a message may be written partially. In that case, the message will be acknowledged once the complete write is successful. If write errors occur during this process, the partially written message may be duplicated. Signed-off-by: László Várady <[email protected]>
Signed-off-by: László Várady <[email protected]>
MrAnno
force-pushed
the
fix-file-writer-proto
branch
from
9614d74 to
024ceb9
Compare
alltilla
approved these changes
Sep 24, 2024
HofiOne
pushed a commit
to HofiOne/axosyslog
that referenced
this pull request
Mar 13, 2025
Signed-off-by: László Várady <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a partial write occurs, the written messages must be acknowledged.
It is important to note that a message may be written partially.
In that case, the message will be acknowledged once the complete write is successful. If write errors occur during this process, the partially written message may be duplicated.