wildcard-file: fix race between EOF and file deletion detection #160
Merged
alltilla merged 2 commits intoaxoflow:mainfrom Jun 13, 2024
Merged
wildcard-file: fix race between EOF and file deletion detection #160alltilla merged 2 commits intoaxoflow:mainfrom
alltilla merged 2 commits intoaxoflow:mainfrom
Conversation
This patch fixes a "race condition" between the EOF and file deletion detection of AxoSyslog when wildcard-file() is used. If a file is written after being deleted (an application keeps an fd open), or if these two events occur concurrently, nearly at the same time, the file poller mechanism might schedule another read cycle while the file has already been marked as fully read and deleted. To avoid scheduling issues between the two checks, the following is done from now on: We do not track the EOF state in the WildcardFileReader, instead, when a file deletion notification is received, the poller will be instructed to stop after reaching the next EOF, and only then will AxoSyslog actually delete the reader instance. Signed-off-by: László Várady <[email protected]>
Signed-off-by: László Várady <[email protected]>
alltilla
approved these changes
Jun 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes a "race condition" between the EOF and file deletion
detection of AxoSyslog when wildcard-file() is used.
If a file is written after being deleted (an application keeps an fd
open), or if these two events occur concurrently, nearly at the same
time, the file poller mechanism might schedule another read cycle while
the file has already been marked as fully read and deleted.
To avoid scheduling issues between the two checks, the following is done
from now on: We do not track the EOF state in the WildcardFileReader,
instead, when a file deletion notification is received, the poller will
be instructed to stop after reaching the next EOF, and only then will
AxoSyslog actually delete the reader instance.
Fixxes syslog-ng/syslog-ng#4989