Implement rfc6587 auto detection#154
Merged
OverOrion merged 13 commits intoaxoflow:mainfrom Dec 4, 2024
Merged
Conversation
alltilla
reviewed
Jun 12, 2024
bazsi
force-pushed
the
implement-rfc6587-auto-detection
branch
from
98435b3 to
c728d0a
Compare
bazsi
force-pushed
the
implement-rfc6587-auto-detection
branch
from
c728d0a to
902b563
Compare
bazsi
force-pushed
the
implement-rfc6587-auto-detection
branch
from
902b563 to
6c992ba
Compare
Member
Author
|
This should wait until #156 is merged. |
bazsi
force-pushed
the
implement-rfc6587-auto-detection
branch
from
6c992ba to
e87919d
Compare
bazsi
changed the title
Member
Author
|
I have now rebased it but still need to check if it works on top of #156 |
bazsi
force-pushed
the
implement-rfc6587-auto-detection
branch
from
e87919d to
85788fb
Compare
Member
|
#156 is now merged, I think we can give this another go (rebase, CI, review, ...) |
bazsi
force-pushed
the
implement-rfc6587-auto-detection
branch
from
85788fb to
7fcd8d2
Compare
bazsi
force-pushed
the
implement-rfc6587-auto-detection
branch
2 times, most recently
from
eec5d17 to
09b5751
Compare
bazsi
changed the title
Member
Author
|
This should now be ready for review. Note: there's a followup PR as well, #361 |
bazsi
force-pushed
the
implement-rfc6587-auto-detection
branch
2 times, most recently
from
6ab04f3 to
594de7b
Compare
Member
Author
|
I have now opted out of doing this by default. The auto-detection mechanism is only enabled with transport(auto) |
bazsi
force-pushed
the
implement-rfc6587-auto-detection
branch
from
594de7b to
ba0325e
Compare
Contributor
This Pull Request introduces config grammar changesaxoflow/9d25570002aaa3c97d7275d119270bd68a6b45d2 -> bazsi/implement-rfc6587-auto-detection Details--- a/destination
+++ b/destination
network(
transport(
+ auto
)
)
syslog(
transport(
+ auto
)
)
--- a/source
+++ b/source
network(
transport(
+ auto
)
)
syslog(
transport(
+ auto
)
)
|
bazsi
force-pushed
the
implement-rfc6587-auto-detection
branch
from
ba0325e to
fa94fef
Compare
Contributor
|
I've started reviewing this patchset, will finish it by the end of the week. |
bazsi
changed the title
OverOrion
reviewed
Dec 2, 2024
Contributor
OverOrion
left a comment
OverOrion
left a comment
There was a problem hiding this comment.
I've reviewed this and tested it manually as well, worked just fine 🚀.
Is there a reason why it's still marked as WIP?
…e is 0 Signed-off-by: Balazs Scheidler <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]>
…ogTransport instances Signed-off-by: Balazs Scheidler <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]>
bazsi
force-pushed
the
implement-rfc6587-auto-detection
branch
from
fa94fef to
6e2ae10
Compare
Signed-off-by: Balazs Scheidler <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]>
…lected Signed-off-by: Balazs Scheidler <[email protected]>
This is just the change in test code, which adds LogProtoServer ** arguments to the handshake related functions, in order to allow log_proto_server_handshake to change the LogProto instance. Signed-off-by: Balazs Scheidler <[email protected]>
This can be used to simplify LogProtoAutoServer. Signed-off-by: Balazs Scheidler <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]>
bazsi
force-pushed
the
implement-rfc6587-auto-detection
branch
from
6e2ae10 to
25d6834
Compare
bazsi
changed the title
Member
Author
|
I pulled some of the later commits into this one, rebased against main and removed WIP. @OverOrion if you can please re-approve, but note that I did pull in some newer changes into this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a pretty common misconfiguration that should be handled automatically.
Just use syslog(transport(auto)) to automatically accept both octet counted and non-octet counted connections, this opens a TCP port without TLS, meaning it is an implementation of RFC6587.