Repository navigation
Commit 667eb3d
fix(test-teardown): restore await on endpoint probe + bump CI/Node to 24
Cycle-2 review findings (Codex + Claude subagent):
1. pid-reuse guard regressed in cycle 1: reapWorkerBrokers dropped the `await`
on `safeAwait(waitForBrokerEndpoint(...))`, so `ready` was an unresolved
Promise (always truthy) → killProcess selected `terminateProcessTree`
unconditionally, even for a dead endpoint whose pid the OS may have
recycled into an unrelated process. The exact invariant the PR claims to
protect. `await` restored; killProcess once again only set when the probe
confirms the broker is live.
2. --test-global-setup needs Node 24, but CI ran Node 22 and engines/lockfile/
README still said 18.18. Bumped all four in lockstep: CI workflow 22→24,
README "Node.js 18.18 or later" → "Node.js 24 or later", package-lock
engines mirrored (already >=24 in package.json from cycle 1).
Cycle-2 cleanup (non-blocking, applied in the final pass):
- reapWorkerBrokers() called with a stray `true` arg from the old signature;
removed.
- registerTrackedTempDir docstring clarified: it covers non-broker temp dirs
only; plugin-data roots go through registerPluginDataDir.
Verified: full npm test → 0 broker leak, 0 leftover test-data dirs; SIGINT
mid-run → 0 leftover. Both reviewers (Codex + Claude subagent) ship.
Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
Claude-Session: https://claude.ai/code/session_0189cGaohsYdpkB4otKZnpAt1 parent 9c798cb commit 667eb3d
4 files changed
Lines changed: 7 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
22 | | - | |
| 22 | + | |
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | | - | |
| 20 | + | |
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
73 | 73 | | |
74 | 74 | | |
75 | 75 | | |
76 | | - | |
| 76 | + | |
| 77 | + | |
77 | 78 | | |
78 | 79 | | |
79 | 80 | | |
| |||
124 | 125 | | |
125 | 126 | | |
126 | 127 | | |
127 | | - | |
| 128 | + | |
128 | 129 | | |
129 | 130 | | |
130 | 131 | | |
| |||
168 | 169 | | |
169 | 170 | | |
170 | 171 | | |
171 | | - | |
| 172 | + | |
172 | 173 | | |
173 | 174 | | |
174 | 175 | | |
| |||
0 commit comments