Merged
Conversation
jasonsaayman
added
priority::high
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 7 files
Confidence score: 4/5
- This PR is likely safe to merge, with minimal risk driven by a single medium-severity dependency consistency issue rather than a runtime breakage.
- The main concern is in
package.json: the ESM smoke fixture lockfile was not updated, so CI may continue validatingproxy-from-env@^1.1.0instead of the newly bumped v2, which can mask integration differences. - Because confidence is high on this finding, it’s worth fixing before or immediately after merge to keep test coverage aligned with the actual dependency graph.
- Pay close attention to
package.json- ensure the ESM smoke fixture lockfile is updated so CI exercises the v2 dependency path.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="package.json">
<violation number="1" location="package.json:167">
P2: Update the ESM smoke fixture lockfile too, or CI will keep testing `proxy-from-env@^1.1.0` instead of the v2 dependency you just bumped.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
|
Hi @jasonsaayman, please can you publish a new version with this in? |
Member
Author
|
will do soon have one or two items to wrap up then i will release, should be this week still |
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Fixes env-based proxy detection and ESM/CJS packaging by upgrading
proxy-from-envto v2, switching togetProxyForUrl, and bundling it in the Node CJS build. Also stabilizes smoke tests by pinningvitestand bumpingesbuild, and cleans up build configs.Description
getProxyForUrlinlib/adapters/http.js.proxy-from-envto^2.0.0.rollup-plugin-auto-externalwith a customexternalto bundleproxy-from-envin the Node CJS build.@babel/core,@babel/preset-env,@rollup/plugin-babel); removeistanbul-instrumenter-loader.vitestto4.0.18in ESM smoke tests; bumpesbuild; refresh root and smoke test lockfiles.mise.toml.proxy-from-envv2 is ESM with named exports; bundling it avoids CJS runtime errors.vitestand updatingesbuildstabilize ESM/CJS smoke tests and reduce lock churn.Docs
No docs updates needed.
Testing
No new unit tests. Updated ESM and CJS smoke test fixtures and lockfiles; verified both builds load and run. Optional: add a test asserting env-based proxy resolution when
config.proxyis undefined.Written for commit c1ad448. Summary will update on new commits.