refactor: remove old test suite update docs#7498
Merged
jasonsaayman merged 4 commits intov1.xfrom Mar 13, 2026
Merged
Conversation
jasonsaayman
added
priority::medium
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
2 issues found across 6 files
Confidence score: 3/5
- There is a concrete regression risk in
.github/workflows/release-branch.yml: thedependency-review-actionstep is likely to fail forworkflow_dispatchruns without PR context (or explicitbase-ref/head-ref), which can break manual release flow execution. package.jsonchanges the defaulttestbehavior to skip package-compat smoke suites and run a headed browser project, increasing the chance of missed compatibility issues and less stable CI defaults.- Given one high-severity workflow failure path and one medium-severity test coverage/defaults change, this carries some merge risk but appears fixable without broad code rewrites.
- Pay close attention to
.github/workflows/release-branch.ymlandpackage.json- workflow dispatch compatibility and test-script default coverage need validation.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="package.json">
<violation number="1" location="package.json:51">
P2: The new `test` script skips the package-compat smoke suites and runs the headed browser project by default.</violation>
</file>
<file name=".github/workflows/release-branch.yml">
<violation number="1" location=".github/workflows/release-branch.yml:48">
P1: This step will fail in a `workflow_dispatch` run because `dependency-review-action` needs a pull-request context or explicit `base-ref`/`head-ref`.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Contributor
There was a problem hiding this comment.
1 issue found across 1 file (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".github/workflows/release-branch.yml">
<violation number="1" location=".github/workflows/release-branch.yml:129">
P2: Avoid persisting checkout credentials in this release job. It leaves a write-capable repo token available to later `npm` scripts even though `create-pull-request` can use its own `GITHUB_TOKEN` input.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Removed the legacy
karma/mochatests and moved CI tovitestwithplaywright. Release PRs are gated on build, unit, browser, and smoke tests, with theaxiosdist uploaded and consumed across jobs.Description
Summary of changes
karma.conf.cjsand removedkarma/mochascripts frompackage.json.vitest(test,test:vitest:*) and kept existingbuild/version scripts.build-and-run-vitestjob, then CJS smoke (Node 12–18 viamocha) and ESM smoke (Node 20–24 viavitest).playwrightinstall step for browser tests.axiosdist artifact and creates the release PR only after all test jobs pass; job names and dependencies updated.cache-dependency-path, artifact handling, consistent quoting).Reasoning
karma/SauceLabs paths and reduce maintenance.Additional context
tests/README.mddocuments structure, naming, and shared utilities for contributors.Docs
tests/README.mdcovering:browser,unit,smoke,setup) and when to use each.tests/setupand fixture conventions.Testing
npm run test:vitest:unitnpm run test:vitest:browser:headlessnpm run test:smoke:cjs:mochanpm run test:smoke:esm:vitestmocha/karmaruns. If any behavior was only covered bykarma, port it tovitestintests/browser.Written for commit 965c4a1. Summary will update on new commits.