Skip to content

docs(buildURL): fix outdated encode() comment#7478

Merged
jasonsaayman merged 2 commits intoaxios:v1.xfrom
nthbotast:docs/buildurl-encode-comment-7474
Mar 12, 2026
Merged

docs(buildURL): fix outdated encode() comment#7478
jasonsaayman merged 2 commits intoaxios:v1.xfrom
nthbotast:docs/buildurl-encode-comment-7474

Conversation

@nthbotast
Copy link
Copy Markdown
Contributor

@nthbotast nthbotast commented Mar 5, 2026

Summary

  • update the encode() JSDoc in lib/helpers/buildURL.js
  • remove outdated mention of [ and ] replacements
  • describe the actual replacements currently implemented (:, $, ,, and spaces to +)

Issue

Validation

  • git diff --check

Summary by cubic

Fix outdated JSDoc for encode() in buildURL to match current behavior. Removes mention of [ and ] and clarifies replacements for :, $, ,, and spaces (+).

Description

Docs

  • Internal JSDoc update only. No public docs changes needed.

Testing

  • No tests changed.
  • Doc-only update; tests not required.

Written for commit 24547f5. Summary will update on new commits.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Copy link
Copy Markdown
Member

@jasonsaayman jasonsaayman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 👋

This PR LGTM 🔥!

Thanks for your contribution to axios

@jasonsaayman jasonsaayman added priority::medium A medium priority commit::docs The PR is related to docs labels Mar 6, 2026
@jasonsaayman jasonsaayman merged commit 042e776 into axios:v1.x Mar 12, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

commit::docs The PR is related to docs priority::medium A medium priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The comment of the function encode() not updated after fix the issue 3316 in the issue 5715

2 participants