docs(buildURL): fix outdated encode() comment#7478
Merged
jasonsaayman merged 2 commits intoaxios:v1.xfrom Mar 12, 2026
Merged
Conversation
jasonsaayman
approved these changes
Mar 6, 2026
Member
jasonsaayman
left a comment
There was a problem hiding this comment.
Hi 👋
This PR LGTM 🔥!
Thanks for your contribution to axios
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issue
encode()not updated after fix the issue 3316 in the issue 5715 #7474Validation
Summary by cubic
Fix outdated JSDoc for encode() in buildURL to match current behavior. Removes mention of [ and ] and clarifies replacements for :, $, ,, and spaces (+).
Description
encode()not updated after fix the issue 3316 in the issue 5715 #7474.Docs
Testing
Written for commit 24547f5. Summary will update on new commits.