feat(http): implement zstd decompression for http adapter#6792
Conversation
|
Updates? |
|
I’m wondering if we could move forward with this. |
|
@BasixKOR, sorry it took me so long to get to this PR. For this to land, can you make the following changes:
|
|
Thanks for looking into this PR :) I'll get the branch sorted and let you know. |
Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
|
@BasixKOR is there a update here? |
|
@jasonsaayman It's ready for review now :) I requested review again for you to look again. |
|
@BasixKOR, I added a gate, else I think conservatively we would need to actually make this a breaking change. Also added some testing updates. |
|
@jasonsaayman Probably, this flag should have been added to the transitional config, as it serves simply to protect against the introduction of a breaking change. Otherwise, we pollute the config with temporary parameters. For example, |
|
Thanks @DigitalBrainJS, yeah, true, I will make a change asap for that. Will also compound it as a rule in the contributing guide, as most contributors don't really do this. Since I used AI to make that change it makes sense it missed the nuance. |
Instructions
Implement #6790. Mostly follows how the Brotli feature detection works, and updates the test code to add zstd test cases.