-
-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added missing colons and period for consistency #6770
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made punctuation improvements by adding missing colons where necessary and inserting a period at the end of a sentence that lacked one. These changes enhance consistency throughout the text, ensuring a uniform formatting style and better readability.
jasonsaayman
approved these changes
Jan 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Hi, @shaymolcho! This PR has been published in v1.8.0 release. Thank you for your contribution ❤️! |
eps-autoapprove-dependabot bot
pushed a commit
to NHSDigital/electronic-prescription-service-account-resources
that referenced
this pull request
Feb 26, 2025
Bumps [axios](https://github.com/axios/axios) from 1.7.9 to 1.8.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/axios/axios/releases">axios's releases</a>.</em></p> <blockquote> <h2>Release v1.8.0</h2> <h2>Release notes:</h2> <h3>Bug Fixes</h3> <ul> <li><strong>examples:</strong> application crashed when navigating examples in browser (<a href="https://redirect.github.com/axios/axios/issues/5938">#5938</a>) (<a href="https://github.com/axios/axios/commit/1260ded634ec101dd5ed05d3b70f8e8f899dba6c">1260ded</a>)</li> <li>missing word in SUPPORT_QUESTION.yml (<a href="https://redirect.github.com/axios/axios/issues/6757">#6757</a>) (<a href="https://github.com/axios/axios/commit/1f890b13f2c25a016f3c84ae78efb769f244133e">1f890b1</a>)</li> <li><strong>utils:</strong> replace getRandomValues with crypto module (<a href="https://redirect.github.com/axios/axios/issues/6788">#6788</a>) (<a href="https://github.com/axios/axios/commit/23a25af0688d1db2c396deb09229d2271cc24f6c">23a25af</a>)</li> </ul> <h3>Features</h3> <ul> <li>Add config for ignoring absolute URLs (<a href="https://redirect.github.com/axios/axios/issues/5902">#5902</a>) (<a href="https://redirect.github.com/axios/axios/issues/6192">#6192</a>) (<a href="https://github.com/axios/axios/commit/32c7bcc0f233285ba27dec73a4b1e81fb7a219b3">32c7bcc</a>)</li> </ul> <h3>Reverts</h3> <ul> <li>Revert "chore: expose fromDataToStream to be consumable (<a href="https://redirect.github.com/axios/axios/issues/6731">#6731</a>)" (<a href="https://redirect.github.com/axios/axios/issues/6732">#6732</a>) (<a href="https://github.com/axios/axios/commit/1317261125e9c419fe9f126867f64d28f9c1efda">1317261</a>), closes <a href="https://redirect.github.com/axios/axios/issues/6731">#6731</a> <a href="https://redirect.github.com/axios/axios/issues/6732">#6732</a></li> </ul> <h3>BREAKING CHANGES</h3> <ul> <li> <p>code relying on the above will now combine the URLs instead of prefer request URL</p> </li> <li> <p>feat: add config option for allowing absolute URLs</p> </li> <li> <p>fix: add default value for allowAbsoluteUrls in buildFullPath</p> </li> <li> <p>fix: typo in flow control when setting allowAbsoluteUrls</p> </li> </ul> <h3>Contributors to this release</h3> <ul> <li><!-- raw HTML omitted --> <a href="https://github.com/GethosTheWalrus" title="+42/-8 ([#6192](axios/axios#6192) )">Michael Toscano</a></li> <li><!-- raw HTML omitted --> <a href="https://github.com/WillianAgostini" title="+26/-3 ([#6788](axios/axios#6788) [#6777](axios/axios#6777) )">Willian Agostini</a></li> <li><!-- raw HTML omitted --> <a href="https://github.com/naronchen" title="+27/-0 ([#5901](axios/axios#5901) )">Naron</a></li> <li><!-- raw HTML omitted --> <a href="https://github.com/shravan20" title="+7/-3 ([#6116](axios/axios#6116) )">shravan || श्रvan</a></li> <li><!-- raw HTML omitted --> <a href="https://github.com/justindhillon" title="+0/-7 ([#6312](axios/axios#6312) )">Justin Dhillon</a></li> <li><!-- raw HTML omitted --> <a href="https://github.com/yionr" title="+5/-1 ([#6129](axios/axios#6129) )">yionr</a></li> <li><!-- raw HTML omitted --> <a href="https://github.com/ueokande" title="+3/-3 ([#5935](axios/axios#5935) )">Shin'ya Ueoka</a></li> <li><!-- raw HTML omitted --> <a href="https://github.com/dandv" title="+3/-3 ([#5908](axios/axios#5908) [#6757](axios/axios#6757) )">Dan Dascalescu</a></li> <li><!-- raw HTML omitted --> <a href="https://github.com/NitinRamnani" title="+2/-2 ([#5938](axios/axios#5938) )">Nitin Ramnani</a></li> <li><!-- raw HTML omitted --> <a href="https://github.com/shaymolcho" title="+2/-2 ([#6770](axios/axios#6770) )">Shay Molcho</a></li> <li><!-- raw HTML omitted --> <a href="https://github.com/jasonsaayman" title="+0/-3 ([#6732](axios/axios#6732) )">Jay</a></li> <li>fancy45daddy</li> <li><!-- raw HTML omitted --> <a href="https://github.com/habipakyol" title="+1/-1 ([#6030](axios/axios#6030) )">Habip Akyol</a></li> <li><!-- raw HTML omitted --> <a href="https://github.com/llamington" title="+1/-1 ([#6771](axios/axios#6771) )">Bailey Lissington</a></li> <li><!-- raw HTML omitted --> <a href="https://github.com/bernardoduarte" title="+1/-1 ([#6480](axios/axios#6480) )">Bernardo da Eira Duarte</a></li> <li><!-- raw HTML omitted --> <a href="https://github.com/Shivam-Batham" title="+1/-1 ([#5949](axios/axios#5949) )">Shivam Batham</a></li> <li><!-- raw HTML omitted --> <a href="https://github.com/lipinnnnn" title="+1/-1 ([#5936](axios/axios#5936) )">Lipin Kariappa</a></li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/axios/axios/blob/v1.x/CHANGELOG.md">axios's changelog</a>.</em></p> <blockquote> <h1><a href="https://github.com/axios/axios/compare/v1.7.9...v1.8.0">1.8.0</a> (2025-02-25)</h1> <h3>Bug Fixes</h3> <ul> <li><strong>examples:</strong> application crashed when navigating examples in browser (<a href="https://redirect.github.com/axios/axios/issues/5938">#5938</a>) (<a href="https://github.com/axios/axios/commit/1260ded634ec101dd5ed05d3b70f8e8f899dba6c">1260ded</a>)</li> <li>missing word in SUPPORT_QUESTION.yml (<a href="https://redirect.github.com/axios/axios/issues/6757">#6757</a>) (<a href="https://github.com/axios/axios/commit/1f890b13f2c25a016f3c84ae78efb769f244133e">1f890b1</a>)</li> <li><strong>utils:</strong> replace getRandomValues with crypto module (<a href="https://redirect.github.com/axios/axios/issues/6788">#6788</a>) (<a href="https://github.com/axios/axios/commit/23a25af0688d1db2c396deb09229d2271cc24f6c">23a25af</a>)</li> </ul> <h3>Features</h3> <ul> <li>Add config for ignoring absolute URLs (<a href="https://redirect.github.com/axios/axios/issues/5902">#5902</a>) (<a href="https://redirect.github.com/axios/axios/issues/6192">#6192</a>) (<a href="https://github.com/axios/axios/commit/32c7bcc0f233285ba27dec73a4b1e81fb7a219b3">32c7bcc</a>)</li> </ul> <h3>Reverts</h3> <ul> <li>Revert "chore: expose fromDataToStream to be consumable (<a href="https://redirect.github.com/axios/axios/issues/6731">#6731</a>)" (<a href="https://redirect.github.com/axios/axios/issues/6732">#6732</a>) (<a href="https://github.com/axios/axios/commit/1317261125e9c419fe9f126867f64d28f9c1efda">1317261</a>), closes <a href="https://redirect.github.com/axios/axios/issues/6731">#6731</a> <a href="https://redirect.github.com/axios/axios/issues/6732">#6732</a></li> </ul> <h3>BREAKING CHANGES</h3> <ul> <li> <p>code relying on the above will now combine the URLs instead of prefer request URL</p> </li> <li> <p>feat: add config option for allowing absolute URLs</p> </li> <li> <p>fix: add default value for allowAbsoluteUrls in buildFullPath</p> </li> <li> <p>fix: typo in flow control when setting allowAbsoluteUrls</p> </li> </ul> <h3>Contributors to this release</h3> <ul> <li><!-- raw HTML omitted --> <a href="https://github.com/GethosTheWalrus" title="+42/-8 ([#6192](axios/axios#6192) )">Michael Toscano</a></li> <li><!-- raw HTML omitted --> <a href="https://github.com/WillianAgostini" title="+26/-3 ([#6788](axios/axios#6788) [#6777](axios/axios#6777) )">Willian Agostini</a></li> <li><!-- raw HTML omitted --> <a href="https://github.com/naronchen" title="+27/-0 ([#5901](axios/axios#5901) )">Naron</a></li> <li><!-- raw HTML omitted --> <a href="https://github.com/shravan20" title="+7/-3 ([#6116](axios/axios#6116) )">shravan || श्रvan</a></li> <li><!-- raw HTML omitted --> <a href="https://github.com/justindhillon" title="+0/-7 ([#6312](axios/axios#6312) )">Justin Dhillon</a></li> <li><!-- raw HTML omitted --> <a href="https://github.com/yionr" title="+5/-1 ([#6129](axios/axios#6129) )">yionr</a></li> <li><!-- raw HTML omitted --> <a href="https://github.com/ueokande" title="+3/-3 ([#5935](axios/axios#5935) )">Shin'ya Ueoka</a></li> <li><!-- raw HTML omitted --> <a href="https://github.com/dandv" title="+3/-3 ([#5908](axios/axios#5908) [#6757](axios/axios#6757) )">Dan Dascalescu</a></li> <li><!-- raw HTML omitted --> <a href="https://github.com/NitinRamnani" title="+2/-2 ([#5938](axios/axios#5938) )">Nitin Ramnani</a></li> <li><!-- raw HTML omitted --> <a href="https://github.com/shaymolcho" title="+2/-2 ([#6770](axios/axios#6770) )">Shay Molcho</a></li> <li><!-- raw HTML omitted --> <a href="https://github.com/jasonsaayman" title="+0/-3 ([#6732](axios/axios#6732) )">Jay</a></li> <li>fancy45daddy</li> <li><!-- raw HTML omitted --> <a href="https://github.com/habipakyol" title="+1/-1 ([#6030](axios/axios#6030) )">Habip Akyol</a></li> <li><!-- raw HTML omitted --> <a href="https://github.com/llamington" title="+1/-1 ([#6771](axios/axios#6771) )">Bailey Lissington</a></li> <li><!-- raw HTML omitted --> <a href="https://github.com/bernardoduarte" title="+1/-1 ([#6480](axios/axios#6480) )">Bernardo da Eira Duarte</a></li> <li><!-- raw HTML omitted --> <a href="https://github.com/Shivam-Batham" title="+1/-1 ([#5949](axios/axios#5949) )">Shivam Batham</a></li> <li><!-- raw HTML omitted --> <a href="https://github.com/lipinnnnn" title="+1/-1 ([#5936](axios/axios#5936) )">Lipin Kariappa</a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/axios/axios/commit/cceb7b1e154fbf294135c93d3f91921643bbe49f"><code>cceb7b1</code></a> chore(release): v1.8.0 (<a href="https://redirect.github.com/axios/axios/issues/6795">#6795</a>)</li> <li><a href="https://github.com/axios/axios/commit/23a25af0688d1db2c396deb09229d2271cc24f6c"><code>23a25af</code></a> fix(utils): replace getRandomValues with crypto module (<a href="https://redirect.github.com/axios/axios/issues/6788">#6788</a>)</li> <li><a href="https://github.com/axios/axios/commit/32c7bcc0f233285ba27dec73a4b1e81fb7a219b3"><code>32c7bcc</code></a> feat: Add config for ignoring absolute URLs (<a href="https://redirect.github.com/axios/axios/issues/5902">#5902</a>) (<a href="https://redirect.github.com/axios/axios/issues/6192">#6192</a>)</li> <li><a href="https://github.com/axios/axios/commit/4a3e26cf65bb040b7eb4577d5fd62199b0f3d017"><code>4a3e26c</code></a> chore(config): adjust rollup config to preserve license header to minified Ja...</li> <li><a href="https://github.com/axios/axios/commit/30966a79cb67e0efc3e91a34b4a39b4d5d50b43e"><code>30966a7</code></a> docs(type): fix typo in index.ts (<a href="https://redirect.github.com/axios/axios/issues/6030">#6030</a>)</li> <li><a href="https://github.com/axios/axios/commit/e7a9cbe3be1ed11689124dd90fbaa5688aaead0e"><code>e7a9cbe</code></a> test(transform): add test case for issue 5853 on response type to 'json' (<a href="https://redirect.github.com/axios/axios/issues/5901">#5901</a>)</li> <li><a href="https://github.com/axios/axios/commit/51c1d7ba9d5b68afad1b0692b2f4350479eb4edd"><code>51c1d7b</code></a> chore(docs): typo in README (<a href="https://redirect.github.com/axios/axios/issues/6771">#6771</a>)</li> <li><a href="https://github.com/axios/axios/commit/b5b063e47602d94a72f163f2233af4f607269c74"><code>b5b063e</code></a> docs(readme): fix Request Config options code highlight (<a href="https://redirect.github.com/axios/axios/issues/6480">#6480</a>)</li> <li><a href="https://github.com/axios/axios/commit/896f9af1bea8685fb948c3a16c20c7e34273e053"><code>896f9af</code></a> chore(docs): remove SECURITY.md (<a href="https://redirect.github.com/axios/axios/issues/6312">#6312</a>)</li> <li><a href="https://github.com/axios/axios/commit/8889dc038348c0109e086eb7fa1a007bb72d621f"><code>8889dc0</code></a> chore(docs): fix documentation for usage of interceptors in axios (<a href="https://redirect.github.com/axios/axios/issues/6116">#6116</a>)</li> <li>Additional commits viewable in <a href="https://github.com/axios/axios/compare/v1.7.9...v1.8.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made punctuation improvements by adding missing colons where necessary and inserting a period at the end of a sentence that lacked one. These changes enhance consistency throughout the text, ensuring a uniform formatting style and better readability.
Instructions
Please read and follow the instructions before creating and submitting a pull request:
Describe your pull request here.