fix(types): default request headers types#4117
Closed
lukashroch wants to merge 2 commits intoaxios:masterfrom
Closed
fix(types): default request headers types#4117lukashroch wants to merge 2 commits intoaxios:masterfrom
lukashroch wants to merge 2 commits intoaxios:masterfrom
Conversation
koddr
approved these changes
Oct 1, 2021
|
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 90205f8 introduced more correct headers types.
However this introduced type issues as request headers are not the same for default request headers (they are distinguished by request method + "common" https://github.com/axios/axios/blob/master/lib/defaults.js#L119), which is causing type issues when working with defaults (#4108). Following change provides proper types for defaults.
edit: added correct type for instance creation as well.