Fixing Mocha tests. #1993
Merged
Fixing Mocha tests. #1993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@emilyemorehouse Build passes. Please consider merging as a temporary workaround to unblock CI verification. |
Member
|
Thank you!! Any chance you've seen a changelog or something for follow-redirects? Did I miss it? I was hoping to find a list of possible breaking changes. |
Author
|
I'm sorry. I was unable to find the changelog either. :( |
emilyemorehouse
pushed a commit
that referenced
this pull request
Jun 1, 2019
|
@emilyemorehouse These are the changes between 1.5.10 and 1.6.0: follow-redirects/follow-redirects@v1.5.10...v1.6.0 |
This was referenced Aug 13, 2019
This was referenced Aug 29, 2019
This was referenced Sep 22, 2019
This was referenced Oct 16, 2019
This was referenced Oct 26, 2019
This was referenced Apr 1, 2020
Closed
This was referenced Apr 9, 2020
This was referenced Apr 18, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLDR: Fixes #1953
Versions 1.6.0 and 1.6.1 of follow-redirects break Mocha test
should support max redirects. The PR updates dependency version to the last compatible one.