Skip to content

makes axios error generic to use axios response #1738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
emilyemorehouse merged 4 commits into from
May 7, 2019
Merged

makes axios error generic to use axios response #1738

emilyemorehouse merged 4 commits into from
May 7, 2019

Conversation

@sumanla13a
Copy link
Contributor

@sumanla13a sumanla13a commented Aug 17, 2018

Regarding #1730

Adjusts index.d.ts so that it takes type argument which is passed on to AxiosResponse.

export interface AxiosError<T = any> extends Error {
  config: AxiosRequestConfig;
  code?: string;
  request?: any;
  response?: AxiosResponse<T>;
}

@JakeSidSmith
Copy link

JakeSidSmith commented Sep 6, 2018

Really need this feature. Was about to open a PR myself. Would be great to get it merged. 🙂

@sumanTitan
Copy link

sumanTitan commented Sep 13, 2018

Can this be merged if this is all right?

@emilyemorehouse emilyemorehouse merged commit 047501f into axios:master May 7, 2019
This was referenced May 7, 2019
Closed
Closed
Closed
@larlew larlew mentioned this pull request Jun 12, 2019
Closed
This was referenced Aug 13, 2019
Open
Open
Closed
This was referenced Aug 29, 2019
Closed
Open
Closed
Open
@snyk-bot snyk-bot mentioned this pull request Sep 12, 2019
Open
This was referenced Sep 22, 2019
Open
Open
Open
Open
Open
@snyk-bot snyk-bot mentioned this pull request Oct 1, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Oct 16, 2019
Merged
This was referenced Apr 1, 2020
Merged
Open
Open
Open
Open
Closed
Merged
Closed
Open
Closed
Closed
Merged
Merged
Merged
Open
Open
This was referenced Apr 9, 2020
Open
Open
Open
Open
This was referenced Apr 18, 2020
Closed
Open
Open
Open
Open
Open
This was referenced Apr 26, 2020
Open
Open
Open
@axios axios locked and limited conversation to collaborators May 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@emilyemorehouse emilyemorehouse emilyemorehouse approved these changes

+2 more reviewers

@JakeSidSmith JakeSidSmith JakeSidSmith approved these changes

@crvN crvN crvN approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sumanla13a @JakeSidSmith @sumanTitan @emilyemorehouse @crvN