Unzipping response body only for statuses != 204 #1129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilyemorehouse
force-pushed
the
master
branch
2 times, most recently
from
2760755 to
48a7902
Compare
OtacilioN
approved these changes
Jan 24, 2019
OtacilioN
left a comment
OtacilioN
left a comment
There was a problem hiding this comment.
Can someone please approve this merge request ❤️ I am facing this issue right now
|
Please merge this! this fixes #1658 |
|
Hey @antonmos I saw that I received an Email from you, unfortunately, I am not maintainer of this repository and I can`t do this. |
|
@emilyemorehouse thanks for merging this! When can we expect a release with this patch? This is causing a production bug for me. |
This was referenced Aug 13, 2019
This was referenced Aug 29, 2019
This was referenced Sep 22, 2019
irembesik
added a commit
to irembesik/blockchain
that referenced
this pull request
Oct 5, 2019
this update has an important change axios/axios#1129
This was referenced Oct 16, 2019
This was referenced Oct 26, 2019
This was referenced Apr 1, 2020
Closed
This was referenced Apr 9, 2020
This was referenced Apr 18, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix
When request has
Content-Encoding: gzip|deflate|compressheader and response has204 No Contentstatus code the following error is thrown:HttpClientError: unexpected end of file.This pull request fixes the issue by calling
stream = stream.pipe(zip.createUnzip())for all status codes but 204.