Skip to content

fix: added missing files from the size comparison#10916

Merged
jasonsaayman merged 1 commit into
v1.xfrom
fix/missing-files-bundle-size
May 19, 2026
Merged

fix: added missing files from the size comparison#10916
jasonsaayman merged 1 commit into
v1.xfrom
fix/missing-files-bundle-size

Conversation

@jasonsaayman
Copy link
Copy Markdown
Member

@jasonsaayman jasonsaayman commented May 19, 2026

Summary

Added missing files from the size comparison action.

Linked issue

N/A

Changes

N/A

Checklist

  • Tests added or updated (or N/A with reason)
  • Docs / types updated if public API changed (index.d.ts and index.d.cts)
  • No breaking changes (or called out explicitly above)

Summary by cubic

Adds the ESM builds to the bundle-size workflow so CI tracks size changes for all distributed formats. This improves visibility and prevents ESM bundle size regressions.

Description

  • Summary of changes
    • Added dist/esm/axios.js and dist/esm/axios.min.js to the bundle-size workflow file list.
  • Reasoning
    • ESM artifacts were missing from size comparison, giving an incomplete view of bundle changes.
  • Additional context
    • CI-only change; no runtime or public API impact.

Docs

  • No docs needed for users.
  • Suggest adding a brief note in /docs/contributing.md (CI section) listing the files tracked by the bundle size check, including the ESM builds.

Testing

  • No unit tests applicable (workflow-only change).
  • CI run will validate that the bundle size report includes the two ESM files.

Semantic version impact

  • No impact. Tooling/CI change only; no release required.

Written for commit 6f10616. Summary will update on new commits. Review in cubic

@jasonsaayman jasonsaayman self-assigned this May 19, 2026
@jasonsaayman jasonsaayman added priority::medium A medium priority commit::fix The PR is related to a bugfix labels May 19, 2026
@jasonsaayman jasonsaayman merged commit 9799184 into v1.x May 19, 2026
26 checks passed
@jasonsaayman jasonsaayman deleted the fix/missing-files-bundle-size branch May 19, 2026 18:13
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

commit::fix The PR is related to a bugfix priority::medium A medium priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant