chore: remove all old and un-needed files#10584
Merged
Merged
Conversation
jasonsaayman
added
priority::low
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
3 issues found across 10 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="tests/module/cjs/tests/typings.module.test.cjs">
<violation number="1" location="tests/module/cjs/tests/typings.module.test.cjs:19">
P2: This test now references `tests/module/esm/tests/helpers/cjs-typing.ts`, but that file does not exist in the repository. The CJS typings test will fail when it tries to create the temp fixture from a missing source file.</violation>
</file>
<file name="tests/module/cjs/tests/ts-require-default.module.test.cjs">
<violation number="1" location="tests/module/cjs/tests/ts-require-default.module.test.cjs:23">
P2: The updated sourcePath points to `tests/module/esm/tests/helpers/ts-require-default.ts`, but that file doesn’t exist in the repo. This will break the test setup when it tries to create the fixture. Use the existing helper path instead.</violation>
</file>
<file name="tests/module/cjs/tests/ts-require.module.test.cjs">
<violation number="1" location="tests/module/cjs/tests/ts-require.module.test.cjs:23">
P2: The new ts-require source path points to a file that doesn’t exist, so this test will fail to create the fixture. Use the existing `tests/module/cjs/tests/helpers/ts-require.ts` path instead.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Contributor
There was a problem hiding this comment.
1 issue found across 8 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="tests/module/cjs/tests/helpers/cjs-typing.ts">
<violation number="1" location="tests/module/cjs/tests/helpers/cjs-typing.ts:1">
P1: `// @ts-nocheck` disables all type validation in this typing test file, undermining the purpose of the CJS typing coverage.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
|
yoo bro you're hacked |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Removed legacy
bin/tooling, templates, and the old test suite. Updated build and GitHub workflow paths toscripts/*; no changes to runtime or publishedaxiosoutputs.Description
A clear and concise description of the PR.
Use this section for review hints, explanations or discussion points.
bin/utilities andtemplates/, and removed the legacytest/suites.bin/githubAxios.jswithscripts/axios-build-instance.jsand droppedcolorizeusage/imports.scripts/update-readme-sponsors.mjs, fixed its import to../index.js, and updated.github/workflows/update-sponsor-block.ymlto call the new path with normalized single quotes.gulpfile.jsto importscripts/axios-build-instance.js.axiosbehavior is unchanged.Docs
scripts/update-readme-sponsors.mjs.Testing
gulptasks run viascripts/axios-build-instance.js, and the sponsor update workflow uses the new script path and completes successfully.Written for commit 5a22319. Summary will update on new commits.