fix: allow passing a callback as paramsSerializer to buildURL (#6680)

guuido · web-flow · commit eac4619fe2e0 · 2024-11-12T17:33:33.000+02:00
* fix: allow passing a callback as paramsSerializer to buildURL

* fix: add missing semicolon
diff --git a/lib/helpers/buildURL.js b/lib/helpers/buildURL.js
@@ -26,7 +26,7 @@ function encode(val) {
  *
  * @param {string} url The base of the url (e.g., http://www.google.com)
  * @param {object} [params] The params to be appended
- * @param {?object} options
+ * @param {?(object|Function)} options
  *
  * @returns {string} The formatted url
  */
@@ -38,6 +38,12 @@ export default function buildURL(url, params, options) {
   
   const _encode = options && options.encode || encode;
 
+  if (utils.isFunction(options)) {
+    options = {
+      serialize: options
+    };
+  } 
+
   const serializeFn = options && options.serialize;
 
   let serializedParams;
diff --git a/test/specs/helpers/buildURL.spec.js b/test/specs/helpers/buildURL.spec.js
@@ -98,5 +98,12 @@ describe('helpers::buildURL', function () {
     };
 
     expect(buildURL('/foo', params, options)).toEqual('/foo?rendered');
+
+    const customSerializer = (thisParams) => {
+      expect(thisParams).toEqual(params);
+      return "rendered"
+    };
+
+    expect(buildURL('/foo', params, customSerializer)).toEqual('/foo?rendered');
   });
 });
