chore(ci): fixed release notification action; (#6063)

DigitalBrainJS · web-flow · commit 7144f10dc51a · 2023-11-08T20:14:12.000+02:00
diff --git a/.github/workflows/notify.yml b/.github/workflows/notify.yml
@@ -0,0 +1,41 @@
+name: notify
+
+on:
+  #workflow_run:
+  #  workflows: ["publish"]
+  #  types:
+  #    - completed
+  #repository_dispatch:
+  #  types: [ notify ]
+  release:
+    types: [ published ]
+  workflow_dispatch:
+    inputs:
+      tag:
+        required: true
+jobs:
+  notify:
+    runs-on: ubuntu-latest
+    #if: ${{ github.event_name == 'workflow_dispatch' || github.event.workflow_run.conclusion == 'success' }}
+    steps:
+      #- name: Dump GitHub context
+      #  env:
+      #    GITHUB_CONTEXT: ${{ toJson(github) }}
+      #  run: echo "$GITHUB_CONTEXT"
+      - uses: actions/checkout@v3
+        with:
+          fetch-depth: 0
+      - name: git config
+        run: |
+          git config user.name "${GITHUB_ACTOR}"
+          git config user.email "${GITHUB_ACTOR}@users.noreply.github.com"
+      - name: Setup node
+        uses: actions/setup-node@v3
+        with:
+          node-version: 18
+          cache: npm
+      - run: npm ci
+      - name: Notify published PRs
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        run: node ./bin/actions/notify_published.js --tag ${{ github.event.inputs.tag || github.event.release.tag_name }}
diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml
@@ -56,8 +56,3 @@ jobs:
         run: npm publish --provenance --access public
         env:
           NODE_AUTH_TOKEN: ${{secrets.npm_token}}
-      ###### NOTIFY & TAG published PRs ######
-      - name: Notify and tag published PRs
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        run: node ./bin/actions/notify_published.js --tag v${{ steps.package-version.outputs.current-version }}
diff --git a/bin/GithubAPI.js b/bin/GithubAPI.js
@@ -105,6 +105,18 @@ export default class GithubAPI {
     } catch (e) {
     }
   }
+
+  static async getLatestTag() {
+    try{
+      const {stdout} = await exec(`git for-each-ref refs/tags --sort=-taggerdate --format='%(refname)' --count=1`);
+
+      return stdout.split('/').pop();
+    } catch (e) {}
+  }
+
+  static normalizeTag(tag){
+    return tag ? 'v' + tag.replace(/^v/, '') : '';
+  }
 }
 
 const {prototype} = GithubAPI;
diff --git a/bin/RepoBot.js b/bin/RepoBot.js
@@ -5,7 +5,7 @@ import fs from "fs/promises";
 import {colorize} from "./helpers/colorize.js";
 import {getReleaseInfo} from "./contributors.js";
 
-const normalizeTag = (tag) => tag.replace(/^v/, '');
+const normalizeTag = (tag) => tag ? 'v' + tag.replace(/^v/, '') : '';
 
 class RepoBot {
   constructor(options) {
@@ -29,7 +29,17 @@ class RepoBot {
   }
 
   async notifyPRPublished(id, tag) {
-    const pr = await this.github.getPR(id);
+    let pr;
+
+    try {
+      pr = await this.github.getPR(id);
+    } catch (err) {
+      if(err.response?.status === 404) {
+        throw new Error(`PR #${id} not found (404)`);
+      }
+
+      throw err;
+    }
 
     tag = normalizeTag(tag);
 
@@ -41,7 +51,7 @@ class RepoBot {
       return false
     }
 
-    await this.github.appendLabels(id, ['v' + tag]);
+    await this.github.appendLabels(id, [tag]);
 
     if (isBot || labels.find(({name}) => name === 'automated pr') || (await this.github.isCollaborator(login))) {
       return false;
@@ -56,14 +66,16 @@ class RepoBot {
       author,
       release: {
         tag,
-        url: `https://github.com/${this.owner}/${this.repo}/releases/tag/v${tag}`
+        url: `https://github.com/${this.owner}/${this.repo}/releases/tag/${tag}`
       }
     });
 
     return await this.addComment(id, message);
   }
 
   async notifyPublishedPRs(tag) {
+    tag = normalizeTag(tag);
+
     const release = await getReleaseInfo(tag);
 
     if (!release) {
@@ -80,9 +92,9 @@ class RepoBot {
       try {
         console.log(colorize()`${i++}) Notify PR #${pr.id}`)
         const result = await this.notifyPRPublished(pr.id, tag);
-        console.log(result ? 'OK' : 'Skipped');
+        console.log('✔️', result ? 'Label, comment' : 'Label');
       } catch (err) {
-        console.warn(colorize('green', 'red')`  Failed notify PR ${pr.id}: ${err.message}`);
+        console.warn(colorize('green', 'red')`❌ Failed notify PR ${pr.id}: ${err.message}`);
       }
     }
   }
diff --git a/bin/actions/notify_published.js b/bin/actions/notify_published.js
@@ -1,18 +1,24 @@
 import minimist from "minimist";
 import RepoBot from '../RepoBot.js';
+import fs from 'fs/promises';
 
 const argv = minimist(process.argv.slice(2));
 console.log(argv);
 
-const tag = argv.tag;
+let {tag} = argv;
 
-if (!tag) {
-  throw new Error('tag must be specified');
-}
+(async() => {
+  if (!tag || tag === true) {
+    const {version} = JSON.parse((await fs.readFile('./package.json')).toString());
 
-const bot = new RepoBot();
+    tag = 'v' + version;
+  } else if (typeof tag !== 'string') {
+
+    throw new Error('tag must be a string');
+  }
+
+  const bot = new RepoBot();
 
-(async() => {
   try {
     await bot.notifyPublishedPRs(tag);
   } catch (err) {
diff --git a/bin/githubAxios.js b/bin/githubAxios.js
@@ -2,6 +2,8 @@ import axios from '../index.js';
 
 const {GITHUB_TOKEN} = process.env;
 
+GITHUB_TOKEN ? console.log(`[GITHUB_TOKEN OK]`) : console.warn(`[GITHUB_TOKEN is not defined]`);
+
 export default axios.create({
   headers: {
     Authorization: GITHUB_TOKEN ? `token ${GITHUB_TOKEN}` : null
diff --git a/package.json b/package.json
@@ -215,4 +215,4 @@
       "@commitlint/config-conventional"
     ]
   }
-}
+}

Original file line number	Diff line number	Diff line change
`@@ -105,6 +105,18 @@ export default class GithubAPI {`
`105`	`105`	`} catch (e) {`
`106`	`106`	`}`
`107`	`107`	`}`
	`108`	`+`
	`109`	`+ static async getLatestTag() {`
	`110`	`+ try{`
	`111`	+ const {stdout} = await exec(`git for-each-ref refs/tags --sort=-taggerdate --format='%(refname)' --count=1`);
	`112`	`+`
	`113`	`+ return stdout.split('/').pop();`
	`114`	`+ } catch (e) {}`
	`115`	`+ }`
	`116`	`+`
	`117`	`+ static normalizeTag(tag){`
	`118`	`+ return tag ? 'v' + tag.replace(/^v/, '') : '';`
	`119`	`+ }`
`108`	`120`	`}`
`109`	`121`
`110`	`122`	`const {prototype} = GithubAPI;`
Original file line number	Diff line number	Diff line change
`@@ -215,4 +215,4 @@`
`215`	`215`	`"@commitlint/config-conventional"`
`216`	`216`	`]`
`217`	`217`	`}`
`218`		`-}`
	`218`	`+}`