fix: unclear error message is thrown when specifying an empty proxy authorization (#6314)

joaoGabriel55 · jasonsaayman · Copilot · web-flow · commit 6ef867e684ad · 2025-11-12T21:04:39.000+02:00
* fix: add AxiosError to Invalid proxy authorization

* fix: minor update

* Update test/unit/adapters/http.js

Co-authored-by: Copilot &lt;175728472+Copilot@users.noreply.github.com&gt;

* chore: remove redundant check

Co-authored-by: Copilot &lt;175728472+Copilot@users.noreply.github.com&gt;

* chore: code style

Co-authored-by: Copilot &lt;175728472+Copilot@users.noreply.github.com&gt;

* chore: style

Co-authored-by: Copilot &lt;175728472+Copilot@users.noreply.github.com&gt;

* chore: correct assert

Co-authored-by: Copilot &lt;175728472+Copilot@users.noreply.github.com&gt;

---------

Co-authored-by: João Gabriel Quaresma de Almeida &lt;joaoGabriel55&gt;
Co-authored-by: Jay &lt;jasonsaayman@gmail.com&gt;
Co-authored-by: Copilot &lt;175728472+Copilot@users.noreply.github.com&gt;
diff --git a/lib/adapters/http.js b/lib/adapters/http.js
@@ -193,12 +193,16 @@ function setProxy(options, configProxy, location) {
 
     if (proxy.auth) {
       // Support proxy auth object form
-      if (proxy.auth.username || proxy.auth.password) {
+      const validProxyAuth = Boolean(proxy.auth.username || proxy.auth.password);
+
+      if (validProxyAuth) {
         proxy.auth = (proxy.auth.username || '') + ':' + (proxy.auth.password || '');
+      } else if (typeof proxy.auth === 'object') {
+        throw new AxiosError('Invalid proxy authorization', AxiosError.ERR_BAD_OPTION, { proxy });
       }
-      const base64 = Buffer
-        .from(proxy.auth, 'utf8')
-        .toString('base64');
+
+      const base64 = Buffer.from(proxy.auth, 'utf8').toString('base64');
+
       options.headers['Proxy-Authorization'] = 'Basic ' + base64;
     }
 
diff --git a/test/unit/adapters/http.js b/test/unit/adapters/http.js
@@ -1361,6 +1361,29 @@ describe('supports http with nodejs', function () {
     });
   });
 
+  describe('when invalid proxy options are provided', function () {
+    it('should throw error', function () {
+      const proxy = {
+        protocol: "http:",
+        host: "hostname.abc.xyz",
+        port: 3300,
+        auth: {
+          username: "",
+          password: "",
+        }
+      };
+
+      return axios.get('https://test-domain.abc', {proxy})
+        .then(function(){
+          assert.fail('Does not throw');
+        }, function (error) {
+          assert.strictEqual(error.message, 'Invalid proxy authorization');
+          assert.strictEqual(error.code, 'ERR_BAD_OPTION');
+          assert.deepStrictEqual(error.config.proxy, proxy);
+        })
+    });
+  });
+
   context('different options for direct proxy configuration (without env variables)', () => {
     const destination = 'www.example.com';
 
